From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Maxim Levitsky <maximlevitsky@gmail.com>
Subject: Re: [PATCH] drivers: memstick: Mark function memstick_debug_get_tpc_name() as static in r592.c
Date: Sat, 14 Dec 2013 12:46:20 -0800 [thread overview]
Message-ID: <20131214204620.GL17601@leaf> (raw)
In-Reply-To: <20131214130717.GA8361@rashika>
On Sat, Dec 14, 2013 at 06:37:18PM +0530, Rashika Kheria wrote:
> This patch marks the function memstick_debug_get_tpc_name() as static in
> host/r592.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in host/r592.c:
> drivers/memstick/host/r592.c:50:13: warning: no previous prototype for ‘memstick_debug_get_tpc_name’ [-Wmissing-prototypes]
In this case, memstick_debug_get_tpc_name is exported. However, nothing
in the kernel uses it. Thus, I'd suggest additionally deleting the
EXPORT_SYMBOL for it, leaving it as a static function only used
internally within that file.
> drivers/memstick/host/r592.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
> index 31727bf..1cd9307 100644
> --- a/drivers/memstick/host/r592.c
> +++ b/drivers/memstick/host/r592.c
> @@ -47,7 +47,7 @@ static const char *tpc_names[] = {
> * memstick_debug_get_tpc_name - debug helper that returns string for
> * a TPC number
> */
> -const char *memstick_debug_get_tpc_name(int tpc)
> +static const char *memstick_debug_get_tpc_name(int tpc)
> {
> return tpc_names[tpc-1];
> }
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-14 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 13:07 [PATCH] drivers: memstick: Mark function memstick_debug_get_tpc_name() as static in r592.c Rashika Kheria
2013-12-14 20:46 ` Josh Triplett [this message]
2013-12-15 19:23 ` [PATCH v2] " Rashika Kheria
2013-12-15 20:13 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214204620.GL17601@leaf \
--to=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox