From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240Ab3LNUrv (ORCPT ); Sat, 14 Dec 2013 15:47:51 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51552 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753862Ab3LNUrt convert rfc822-to-8bit (ORCPT ); Sat, 14 Dec 2013 15:47:49 -0500 X-Originating-IP: 50.43.14.201 Date: Sat, 14 Dec 2013 12:47:13 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Tejun Heo , linux-ide@vger.kernel.org Subject: Re: [PATCH 1/2] drivers: ata: Mark the function ahci_init_interrupts() as static in ahci.c Message-ID: <20131214204712.GM17601@leaf> References: <81391ee13d565f1db31247dfda803cd7123bb8a9.1387029964.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <81391ee13d565f1db31247dfda803cd7123bb8a9.1387029964.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 14, 2013 at 07:38:08PM +0530, Rashika Kheria wrote: > This patch marks the function ahci_init_interrupts() as static in ahci.c > because it is not used outside this file. > > Thus, it also eliminates the following warning in ahci.c: > drivers/ata/ahci.c:1099:5: warning: no previous prototype for ‘ahci_init_interrupts’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/ata/ahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 14f1e95..4ab1d41 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -1097,7 +1097,7 @@ static inline void ahci_gtf_filter_workaround(struct ata_host *host) > {} > #endif > > -int ahci_init_interrupts(struct pci_dev *pdev, struct ahci_host_priv *hpriv) > +static int ahci_init_interrupts(struct pci_dev *pdev, struct ahci_host_priv *hpriv) > { > int rc; > unsigned int maxvec; > -- > 1.7.9.5 >