[PATCH] drivers: char: Include appropriate header file in frontend.c

[PATCH] drivers: char: Include appropriate header file in frontend.c

[Rashika Kheria]

This patch includes appropriate header file compat_ioctl.h in
agp/frontend.c because functions agp_find_mem_by_key(),
agp_create_segment(), agp_find_private(), agp_free_memory_wrap(),
agp_allocate_memory_wrap(), agp_find_client_by_pid(),
agp_create_client(), agp_remove_client(), agpioc_acquire_wrap(),
agpioc_release_wrap(), agpioc_setup_wrap(), agpioc_protect_wrap() and
agpioc_deallocate_wrap() have their prototype declaration in
compat_ioctl.h.

Thus, it also eliminates the following warnings in agp/frontend.c:
drivers/char/agp/frontend.c:48:20: warning: no previous prototype for ‘agp_find_mem_by_key’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:164:5: warning: no previous prototype for ‘agp_create_segment’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:216:26: warning: no previous prototype for ‘agp_find_private’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:271:6: warning: no previous prototype for ‘agp_free_memory_wrap’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:277:20: warning: no previous prototype for ‘agp_allocate_memory_wrap’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:489:20: warning: no previous prototype for ‘agp_find_client_by_pid’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:514:20: warning: no previous prototype for ‘agp_create_client’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:527:5: warning: no previous prototype for ‘agp_remove_client’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:750:5: warning: no previous prototype for ‘agpioc_acquire_wrap’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:793:5: warning: no previous prototype for ‘agpioc_release_wrap’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:800:5: warning: no previous prototype for ‘agpioc_setup_wrap’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:880:5: warning: no previous prototype for ‘agpioc_protect_wrap’ [-Wmissing-prototypes]
drivers/char/agp/frontend.c:914:5: warning: no previous prototype for ‘agpioc_deallocate_wrap’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/char/agp/frontend.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c
index 1b19239..79c8666 100644
--- a/drivers/char/agp/frontend.c
+++ b/drivers/char/agp/frontend.c
@@ -42,6 +42,7 @@
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>
 #include "agp.h"
+#include "compat_ioctl.h"
 
 struct agp_front_data agp_fe;
 
-- 
1.7.9.5

Re: [PATCH] drivers: char: Include appropriate header file in frontend.c

[Josh Triplett]

On Sat, Dec 14, 2013 at 07:21:48PM +0530, Rashika Kheria wrote:
> This patch includes appropriate header file compat_ioctl.h in
> agp/frontend.c because functions agp_find_mem_by_key(),
> agp_create_segment(), agp_find_private(), agp_free_memory_wrap(),
> agp_allocate_memory_wrap(), agp_find_client_by_pid(),
> agp_create_client(), agp_remove_client(), agpioc_acquire_wrap(),
> agpioc_release_wrap(), agpioc_setup_wrap(), agpioc_protect_wrap() and
> agpioc_deallocate_wrap() have their prototype declaration in
> compat_ioctl.h.
> 
> Thus, it also eliminates the following warnings in agp/frontend.c:
> drivers/char/agp/frontend.c:48:20: warning: no previous prototype for ‘agp_find_mem_by_key’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:164:5: warning: no previous prototype for ‘agp_create_segment’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:216:26: warning: no previous prototype for ‘agp_find_private’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:271:6: warning: no previous prototype for ‘agp_free_memory_wrap’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:277:20: warning: no previous prototype for ‘agp_allocate_memory_wrap’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:489:20: warning: no previous prototype for ‘agp_find_client_by_pid’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:514:20: warning: no previous prototype for ‘agp_create_client’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:527:5: warning: no previous prototype for ‘agp_remove_client’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:750:5: warning: no previous prototype for ‘agpioc_acquire_wrap’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:793:5: warning: no previous prototype for ‘agpioc_release_wrap’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:800:5: warning: no previous prototype for ‘agpioc_setup_wrap’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:880:5: warning: no previous prototype for ‘agpioc_protect_wrap’ [-Wmissing-prototypes]
> drivers/char/agp/frontend.c:914:5: warning: no previous prototype for ‘agpioc_deallocate_wrap’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/char/agp/frontend.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c
> index 1b19239..79c8666 100644
> --- a/drivers/char/agp/frontend.c
> +++ b/drivers/char/agp/frontend.c
> @@ -42,6 +42,7 @@
>  #include <asm/uaccess.h>
>  #include <asm/pgtable.h>
>  #include "agp.h"
> +#include "compat_ioctl.h"
>  
>  struct agp_front_data agp_fe;
>  
> -- 
> 1.7.9.5
>