From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
devel@linuxdriverproject.org
Subject: Re: [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c
Date: Sat, 14 Dec 2013 12:57:17 -0800 [thread overview]
Message-ID: <20131214205717.GR17601@leaf> (raw)
In-Reply-To: <20131214133006.GA8773@rashika>
On Sat, Dec 14, 2013 at 07:00:06PM +0530, Rashika Kheria wrote:
> This patch marks the function hv_synic_free_cpu() as static in hv.c
> because it is not used outside this file.
>
> Thus, it also eliminates the following warning in hv.c:
> drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/hv/hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index f0c5e07..bcb4950 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -301,7 +301,7 @@ err:
> return -ENOMEM;
> }
>
> -void hv_synic_free_cpu(int cpu)
> +static void hv_synic_free_cpu(int cpu)
> {
> kfree(hv_context.event_dpc[cpu]);
> if (hv_context.synic_event_page[cpu])
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-14 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 13:30 [PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c Rashika Kheria
2013-12-14 20:57 ` Josh Triplett [this message]
2013-12-14 22:11 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214205717.GR17601@leaf \
--to=josh@joshtriplett.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox