From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, Dan Williams <djbw@fb.com>,
Maciej Sosnowski <maciej.sosnowski@intel.com>
Subject: Re: [PATCH] drivers: dca: Mark the function dca_common_get_tag() as static in dca-core.c
Date: Sat, 14 Dec 2013 12:58:10 -0800 [thread overview]
Message-ID: <20131214205810.GT17601@leaf> (raw)
In-Reply-To: <20131214134436.GA13211@rashika>
On Sat, Dec 14, 2013 at 07:14:36PM +0530, Rashika Kheria wrote:
> This patch marks the function dca_common_get_tag() as static in
> dca-core.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in dca-core.c:
> drivers/dca/dca-core.c:273:4: warning: no previous prototype for ‘dca_common_get_tag’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/dca/dca-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c
> index 819dfda..9096e59 100644
> --- a/drivers/dca/dca-core.c
> +++ b/drivers/dca/dca-core.c
> @@ -270,7 +270,7 @@ EXPORT_SYMBOL_GPL(dca_remove_requester);
> * @dev - the device that wants dca service
> * @cpu - the cpuid as returned by get_cpu()
> */
> -u8 dca_common_get_tag(struct device *dev, int cpu)
> +static u8 dca_common_get_tag(struct device *dev, int cpu)
> {
> struct dca_provider *dca;
> u8 tag;
> --
> 1.7.9.5
>
prev parent reply other threads:[~2013-12-14 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 13:44 [PATCH] drivers: dca: Mark the function dca_common_get_tag() as static in dca-core.c Rashika Kheria
2013-12-14 20:58 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214205810.GT17601@leaf \
--to=josh@joshtriplett.org \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox