* [PATCH] drivers: dca: Mark the function dca_common_get_tag() as static in dca-core.c
@ 2013-12-14 13:44 Rashika Kheria
2013-12-14 20:58 ` Josh Triplett
0 siblings, 1 reply; 2+ messages in thread
From: Rashika Kheria @ 2013-12-14 13:44 UTC (permalink / raw)
To: linux-kernel; +Cc: Dan Williams, Maciej Sosnowski, Rashika Kheria, josh
This patch marks the function dca_common_get_tag() as static in
dca-core.c because it is not used outside this file.
Thus, it also eliminates the following warning in dca-core.c:
drivers/dca/dca-core.c:273:4: warning: no previous prototype for ‘dca_common_get_tag’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/dca/dca-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c
index 819dfda..9096e59 100644
--- a/drivers/dca/dca-core.c
+++ b/drivers/dca/dca-core.c
@@ -270,7 +270,7 @@ EXPORT_SYMBOL_GPL(dca_remove_requester);
* @dev - the device that wants dca service
* @cpu - the cpuid as returned by get_cpu()
*/
-u8 dca_common_get_tag(struct device *dev, int cpu)
+static u8 dca_common_get_tag(struct device *dev, int cpu)
{
struct dca_provider *dca;
u8 tag;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: dca: Mark the function dca_common_get_tag() as static in dca-core.c
2013-12-14 13:44 [PATCH] drivers: dca: Mark the function dca_common_get_tag() as static in dca-core.c Rashika Kheria
@ 2013-12-14 20:58 ` Josh Triplett
0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2013-12-14 20:58 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, Dan Williams, Maciej Sosnowski
On Sat, Dec 14, 2013 at 07:14:36PM +0530, Rashika Kheria wrote:
> This patch marks the function dca_common_get_tag() as static in
> dca-core.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in dca-core.c:
> drivers/dca/dca-core.c:273:4: warning: no previous prototype for ‘dca_common_get_tag’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/dca/dca-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c
> index 819dfda..9096e59 100644
> --- a/drivers/dca/dca-core.c
> +++ b/drivers/dca/dca-core.c
> @@ -270,7 +270,7 @@ EXPORT_SYMBOL_GPL(dca_remove_requester);
> * @dev - the device that wants dca service
> * @cpu - the cpuid as returned by get_cpu()
> */
> -u8 dca_common_get_tag(struct device *dev, int cpu)
> +static u8 dca_common_get_tag(struct device *dev, int cpu)
> {
> struct dca_provider *dca;
> u8 tag;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-14 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 13:44 [PATCH] drivers: dca: Mark the function dca_common_get_tag() as static in dca-core.c Rashika Kheria
2013-12-14 20:58 ` Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox