[PATCH] drivers: pnp: Mark the function pnp_build_option() as static in resource.c

[PATCH] drivers: pnp: Mark the function pnp_build_option() as static in resource.c

[Rashika Kheria]

This patch marks the function pnp_build_option() as static in resource.c
because it is not used outside this file.

Thus, it also eliminates the following warning in resource.c:
drivers/pnp/resource.c:34:20: warning: no previous prototype for ‘pnp_build_option’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/pnp/resource.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
index d95e101..bacddd1 100644
--- a/drivers/pnp/resource.c
+++ b/drivers/pnp/resource.c
@@ -31,7 +31,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
  * option registration
  */
 
-struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
+static struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
 				    unsigned int option_flags)
 {
 	struct pnp_option *option;
-- 
1.7.9.5

Re: [PATCH] drivers: pnp: Mark the function pnp_build_option() as static in resource.c

[Josh Triplett]

On Sat, Dec 14, 2013 at 06:50:56PM +0530, Rashika Kheria wrote:
> This patch marks the function pnp_build_option() as static in resource.c
> because it is not used outside this file.
> 
> Thus, it also eliminates the following warning in resource.c:
> drivers/pnp/resource.c:34:20: warning: no previous prototype for ‘pnp_build_option’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/pnp/resource.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> index d95e101..bacddd1 100644
> --- a/drivers/pnp/resource.c
> +++ b/drivers/pnp/resource.c
> @@ -31,7 +31,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
>   * option registration
>   */
>  
> -struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
> +static struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
>  				    unsigned int option_flags)
>  {
>  	struct pnp_option *option;
> -- 
> 1.7.9.5
> 

Re: [PATCH] drivers: pnp: Mark the function pnp_build_option() as static in resource.c

[Rafael J. Wysocki]

On Saturday, December 14, 2013 12:58:37 PM Josh Triplett wrote:
> On Sat, Dec 14, 2013 at 06:50:56PM +0530, Rashika Kheria wrote:
> > This patch marks the function pnp_build_option() as static in resource.c
> > because it is not used outside this file.
> > 
> > Thus, it also eliminates the following warning in resource.c:
> > drivers/pnp/resource.c:34:20: warning: no previous prototype for ‘pnp_build_option’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> 
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Queued up for 3.14, thanks!

> >  drivers/pnp/resource.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> > index d95e101..bacddd1 100644
> > --- a/drivers/pnp/resource.c
> > +++ b/drivers/pnp/resource.c
> > @@ -31,7 +31,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 };	/* reserve (don't use) some
> >   * option registration
> >   */
> >  
> > -struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
> > +static struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
> >  				    unsigned int option_flags)
> >  {
> >  	struct pnp_option *option;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.