Re: [PATCH] drivers: mmc: Mark the function sdhci_disable_irq_wakeups() as static in sdhci.c

Josh Triplett
2013-12-14T21:00:31Z

On Sat, Dec 14, 2013 at 06:46:31PM +0530, Rashika Kheria wrote:
> This patch marks the function sdhci_disable_irq_wakeups() as static in
> host/sdhci.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in host/sdhci.c:
> drivers/mmc/host/sdhci.c:2553:6: warning: no previous prototype for ‘sdhci_disable_irq_wakeups’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

This function has an EXPORT_SYMBOL_GPL, making it available for use
elsewhere in the kernel. However, nothing in the kernel actually
*calls* this function, other than the one internal call in
sdhci_resume_host. Thus, I'd suggest making this function static as you
have in this patch, and additionally deleting the EXPORT_SYMBOL_GPL for
it.

With that change:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> drivers/mmc/host/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index bd8a098..8de50e8 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2550,7 +2550,7 @@ void sdhci_enable_irq_wakeups(struct sdhci_host *host)
> }
> EXPORT_SYMBOL_GPL(sdhci_enable_irq_wakeups);
>
> -void sdhci_disable_irq_wakeups(struct sdhci_host *host)
> +static void sdhci_disable_irq_wakeups(struct sdhci_host *host)
> {
> u8 val;
> u8 mask = SDHCI_WAKE_ON_INSERT | SDHCI_WAKE_ON_REMOVE
> --
> 1.7.9.5
>