Re: [PATCH v2] drivers: memstick: Mark function memstick_debug_get_tpc_name() as static in r592.c

[Josh Triplett <josh@joshtriplett.org>]

On Mon, Dec 16, 2013 at 12:53:02AM +0530, Rashika Kheria wrote:
> This patch marks the function memstick_debug_get_tpc_name() as static in
> host/r592.c because it is not used outside this file. It also removes the
> EXPORT_SYMBOL because the function is not used anywhere else in the
> kernel.
> 
> Thus, it also eliminates the following warning in host/r592.c:
> drivers/memstick/host/r592.c:50:13: warning: no previous prototype for ‘memstick_debug_get_tpc_name’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/memstick/host/r592.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
> index 31727bf..d03aacb 100644
> --- a/drivers/memstick/host/r592.c
> +++ b/drivers/memstick/host/r592.c
> @@ -47,12 +47,10 @@ static const char *tpc_names[] = {
>   * memstick_debug_get_tpc_name - debug helper that returns string for
>   * a TPC number
>   */
> -const char *memstick_debug_get_tpc_name(int tpc)
> +static const char *memstick_debug_get_tpc_name(int tpc)
>  {
>  	return tpc_names[tpc-1];
>  }
> -EXPORT_SYMBOL(memstick_debug_get_tpc_name);
> -
>  
>  /* Read a register*/
>  static inline u32 r592_read_reg(struct r592_device *dev, int address)
> -- 
> 1.7.9.5
>