public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Andrew Bresticker <abrestic@chromium.org>,
	Vincent Palatin <vpalatin@chromium.org>,
	Rhyland Klein <rklein@nvidia.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] mfd: cros ec: spi: Add delay for raising CS
Date: Mon, 16 Dec 2013 13:50:50 +0000	[thread overview]
Message-ID: <20131216135050.GJ18769@lee--X1> (raw)
In-Reply-To: <1387192180-15333-1-git-send-email-treding@nvidia.com>

> From: Rhyland Klein <rklein@nvidia.com>
> 
> The EC has specific timing it requires. Add support for an optional delay
> after raising CS to fix timing issues. This is configurable based on
> a DT property "google,cros-ec-spi-msg-delay".
> 
> If this property isn't set, then no delay will be added. However, if set
> it will cause a delay equal to the value passed to it to be inserted at
> the end of a transaction.
> 
> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
> Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
> Reviewed-by: Andrew Bresticker <abrestic@chromium.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Changes in v5:
> - modify correct hunk to use 0 instead of '\0'
> - add Mark's Acked-by
> 
> Changes in v4:
> - unconditionally call cros_ec_spi_dt_probe() since the driver now
>   depends on OF
> 
> Changes in v3:
> - rename cros_ec_probe_spi_dt() to cros_ec_spi_dt_probe()
> - use 0 instead of '\0'
> 
> Changes in v2:
> - make property description more verbose
> 
>  Documentation/devicetree/bindings/mfd/cros-ec.txt |  9 +++++++
>  drivers/mfd/cros_ec_spi.c                         | 29 +++++++++++++++++++++++
>  2 files changed, 38 insertions(+)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

      parent reply	other threads:[~2013-12-16 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 11:09 [PATCH v5 1/2] mfd: cros ec: spi: Add delay for raising CS Thierry Reding
2013-12-16 11:09 ` [PATCH v5 2/2] mfd: cros ec: spi: Use 0 instead of '\0' consistently Thierry Reding
2013-12-16 13:51   ` Lee Jones
2013-12-16 13:50 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216135050.GJ18769@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=abrestic@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rklein@nvidia.com \
    --cc=sameo@linux.intel.com \
    --cc=thierry.reding@gmail.com \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox