Re: [PATCH v5 1/2] mfd: cros ec: spi: Add delay for raising CS

Lee Jones
2013-12-16T13:50:59Z

> From: Rhyland Klein <rklein@nvidia.com>
>
> The EC has specific timing it requires. Add support for an optional delay
> after raising CS to fix timing issues. This is configurable based on
> a DT property "google,cros-ec-spi-msg-delay".
>
> If this property isn't set, then no delay will be added. However, if set
> it will cause a delay equal to the value passed to it to be inserted at
> the end of a transaction.
>
> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
> Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
> Reviewed-by: Andrew Bresticker <abrestic@chromium.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Changes in v5:
> - modify correct hunk to use 0 instead of '\0'
> - add Mark's Acked-by
>
> Changes in v4:
> - unconditionally call cros_ec_spi_dt_probe() since the driver now
> depends on OF
>
> Changes in v3:
> - rename cros_ec_probe_spi_dt() to cros_ec_spi_dt_probe()
> - use 0 instead of '\0'
>
> Changes in v2:
> - make property description more verbose
>
> Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++++++
> drivers/mfd/cros_ec_spi.c | 29 +++++++++++++++++++++++
> 2 files changed, 38 insertions(+)

Applied, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog