From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754418Ab3LPOXs (ORCPT ); Mon, 16 Dec 2013 09:23:48 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47896 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384Ab3LPOXr convert rfc822-to-8bit (ORCPT ); Mon, 16 Dec 2013 09:23:47 -0500 X-Originating-IP: 50.43.14.201 Date: Mon, 16 Dec 2013 06:23:38 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Rusty Russell , "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Message-ID: <20131216142338.GA24172@leaf> References: <20131216112408.GA4896@rashika> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20131216112408.GA4896@rashika> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote: > Mark the function virtballoon_migratepage() as static in > virtio_balloon.c because it is not used outside this file. > > This eliminates the following warning in virtio_balloon.c: > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index c444654..8c5943d 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops; > * This function preforms the balloon page migration task. > * Called through balloon_mapping->a_ops->migratepage > */ > -int virtballoon_migratepage(struct address_space *mapping, > +static int virtballoon_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, enum migrate_mode mode) > { > struct balloon_dev_info *vb_dev_info = balloon_page_device(page); > -- > 1.7.9.5 >