From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754468Ab3LPOYd (ORCPT ); Mon, 16 Dec 2013 09:24:33 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:58737 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754179Ab3LPOYc convert rfc822-to-8bit (ORCPT ); Mon, 16 Dec 2013 09:24:32 -0500 X-Originating-IP: 50.43.14.201 Date: Mon, 16 Dec 2013 06:24:23 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org Subject: Re: [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c Message-ID: <20131216142423.GB24172@leaf> References: <20131216112110.GA4849@rashika> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20131216112110.GA4849@rashika> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2013 at 04:51:10PM +0530, Rashika Kheria wrote: > Removes unused function genericbl_limit_intensity() in > backlight/generic_bl.c. > > This eliminates the following warning in backlight/generic_bl.c: > drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for ‘genericbl_limit_intensity’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/video/backlight/generic_bl.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c > index 5d8d652..67dfb93 100644 > --- a/drivers/video/backlight/generic_bl.c > +++ b/drivers/video/backlight/generic_bl.c > @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd) > return genericbl_intensity; > } > > -/* > - * Called when the battery is low to limit the backlight intensity. > - * If limit==0 clear any limit, otherwise limit the intensity > - */ > -void genericbl_limit_intensity(int limit) > -{ > - struct backlight_device *bd = generic_backlight_device; > - > - mutex_lock(&bd->ops_lock); > - if (limit) > - bd->props.state |= GENERICBL_BATTLOW; > - else > - bd->props.state &= ~GENERICBL_BATTLOW; > - backlight_update_status(generic_backlight_device); > - mutex_unlock(&bd->ops_lock); > -} > -EXPORT_SYMBOL(genericbl_limit_intensity); > - > static const struct backlight_ops genericbl_ops = { > .options = BL_CORE_SUSPENDRESUME, > .get_brightness = genericbl_get_intensity, > -- > 1.7.9.5 >