public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Levente Kurusa <levex@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] treewide: add missing put_device calls
Date: Mon, 16 Dec 2013 09:58:48 -0800	[thread overview]
Message-ID: <20131216175848.GB2007@kroah.com> (raw)
In-Reply-To: <52AF35FD.8000904@linux.com>

On Mon, Dec 16, 2013 at 06:18:53PM +0100, Levente Kurusa wrote:
> >> IIRC, there are also a few where the device is also unregistered from
> >> the specific subsystem's core.
> > 
> > Do you have a specific example of this?  This should happen in the
> > release function of the device already, not in some other code.
> > 
> Character drivers who register with device_register() call cdev_del()
> when device_register() fails.

A cdev shouldn't be created until _after_ the device is successfully
registered, as it could be opened and accessed before the device is
registered.  That sounds like the drivers that do that should be fixed
(have an example of this somewhere?)

> cdev_del() in turn calls kobject_put on the kobject of the device.

Which device?  Don't get confused about the internal kobject for a cdev,
that's a totally different thing.

thanks,

greg k-h

  reply	other threads:[~2013-12-16 17:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 19:22 [PATCH 0/4] treewide: add missing put_device calls Levente Kurusa
2013-12-13 19:22 ` [PATCH 1/4] net: phy: call put_device on device_register() failure Levente Kurusa
2013-12-13 19:22 ` [PATCH 2/4] eisa: call put_device if device_register fails Levente Kurusa
2013-12-13 19:22 ` [PATCH 3/4] backlight: lcd: " Levente Kurusa
2013-12-13 19:22 ` [PATCH 4/4] w1: " Levente Kurusa
2013-12-14 15:17   ` Evgeniy Polyakov
2013-12-18 23:47     ` Greg KH
2013-12-23 15:37       ` Джамурахметов Рустафа
2013-12-23 15:38       ` Evgeniy Polyakov
2013-12-13 20:42 ` [PATCH 0/4] treewide: add missing put_device calls Bjorn Helgaas
2013-12-14 17:24   ` Greg Kroah-Hartman
2013-12-15  7:55     ` Levente Kurusa
2013-12-15 17:03       ` Greg Kroah-Hartman
2013-12-16 17:18         ` Levente Kurusa
2013-12-16 17:58           ` Greg Kroah-Hartman [this message]
2013-12-16 18:11             ` Levente Kurusa
2013-12-16 18:18               ` Greg Kroah-Hartman
2013-12-16 18:24                 ` Levente Kurusa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216175848.GB2007@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhelgaas@google.com \
    --cc=levex@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox