Re: [PATCH 2/7] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

Mark Brown
2014-01-03T00:50:27Z

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On Thu, Jan 02, 2014 at 11:17:57AM -0800, Dmitry Torokhov wrote:
> On Thu, Jan 02, 2014 at 06:49:59PM +0000, Mark Brown wrote:
> > On Sun, Dec 15, 2013 at 03:33:37AM -0800, Dmitry Torokhov wrote:

> > > > + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > > > + if (!regmap)
> > > > + return -ENODEV;

> > > And you are leaking memory here...

> > He's not, dev_get_regmap() just gets a pointer to an existing regmap -
> > no reference is taken and nothing is allocated. It's a helper that's

> I was not talking about data returned by dev_get_regmap() but all other
> memory that was allocated before as this was pre devm conversion of the
> driver.

Ah, OK - I thought you meant that as that was the code immediately prior
to your reply. Sorry for the confusion.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]