Re: [PATCH 6/7] Input: pmic8xxx-keypad - Migrate to devm_* APIs

spamassassin system account
2013-12-17T02:01:55Z

On 12/16, Dmitry Torokhov wrote:
> On Tue, Dec 10, 2013 at 03:43:15PM -0800, Stephen Boyd wrote:
> > -
> > -static int pmic8xxx_kp_remove(struct platform_device *pdev)
> > -{
> > - struct pmic8xxx_kp *kp = platform_get_drvdata(pdev);
> > -
> > - device_init_wakeup(&pdev->dev, 0);
>
> Why are we removing restoring wakeup capable state?
>

It's the only thing blocking removal of the remove callback and
as the driver is being unbound it didn't seem like we cared about
the state of the wakeup of the device. I greped the kernel tree
and I couldn't see a consistent pattern where driver probe was
setting the flag and driver remove was clearing it. Do we need to
keep it?

> > - free_irq(kp->key_stuck_irq, kp);
> > - free_irq(kp->key_sense_irq, kp);
> > - input_unregister_device(kp->input);
> > - kfree(kp);
> > -
> > - return 0;
> > }
> >
> > #ifdef CONFIG_PM_SLEEP

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,