Re: [PATCH 2/7] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

Mark Brown
2014-01-02T18:50:26Z

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

On Sun, Dec 15, 2013 at 03:33:37AM -0800, Dmitry Torokhov wrote:
> On Tue, Dec 10, 2013 at 03:43:11PM -0800, Stephen Boyd wrote:

> > + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > + if (!regmap)
> > + return -ENODEV;

> And you are leaking memory here...

He's not, dev_get_regmap() just gets a pointer to an existing regmap -
no reference is taken and nothing is allocated. It's a helper that's
mainly there so that generic code can be written without needing the
regmap to be passed around. The caller is responsible for ensuring that
it will stick around for as long as it's used (generally by having it
lifetime managed with the device).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]