From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893Ab3LQNYD (ORCPT ); Tue, 17 Dec 2013 08:24:03 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:34072 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753839Ab3LQNYB (ORCPT ); Tue, 17 Dec 2013 08:24:01 -0500 Date: Tue, 17 Dec 2013 13:23:55 +0000 From: Lee Jones To: Laszlo Papp Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: max8997: Enforce mfd_add_devices() return value check Message-ID: <20131217132355.GG19810@lee--X1> References: <1387284591-28615-1-git-send-email-lpapp@kde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1387284591-28615-1-git-send-email-lpapp@kde.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Dec 2013, Laszlo Papp wrote: > The original author provided a random return value check which is > redundant and seemingly floating. This patch not only relocates > the check so it is more clearly associated with the invokation of > mfd_add_devices(), but provides a store for the error value. We > also print a meaningful message on error before returning. > > Signed-off-by: Laszlo Papp > --- > drivers/mfd/max8997.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog