From: Dan Carpenter <dan.carpenter@oracle.com>
To: micky_ching@realsil.com.cn
Cc: sameo@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
rogerable@realtek.com, devel@linuxdriverproject.org
Subject: Re: [PATCH v4 0/2] mfd: rtsx: decrease driver size and add new device
Date: Wed, 18 Dec 2013 09:53:39 +0300 [thread overview]
Message-ID: <20131218065339.GB28413@mwanda> (raw)
In-Reply-To: <cover.1387331869.git.micky_ching@realsil.com.cn>
On Wed, Dec 18, 2013 at 10:03:11AM +0800, micky_ching@realsil.com.cn wrote:
> From: Micky Ching <micky_ching@realsil.com.cn>
>
> we add a macro to simplify setting pull control, and use a common init
> function to init the common params for 8411-like chips. at last we add
> support for rtl8402 chip.
>
> Micky Ching (2):
> mfd: rtsx: add set pull control macro and simplify rtl8411
> mfd: rtsx: add support for card reader rtl8402
>
> drivers/mfd/rtl8411.c | 95 ++++++++++++++++++++++++++----------------------
> drivers/mfd/rtsx_pcr.c | 5 +++
> drivers/mfd/rtsx_pcr.h | 9 +++++
> 3 files changed, 66 insertions(+), 43 deletions(-)
>
Great. Looks good to me.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2013-12-18 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 2:03 [PATCH v4 0/2] mfd: rtsx: decrease driver size and add new device micky_ching
2013-12-18 2:03 ` [PATCH v4 1/2] mfd: rtsx: add set pull control macro and simplify rtl8411 micky_ching
2013-12-18 2:03 ` [PATCH v4 2/2] mfd: rtsx: add support for card reader rtl8402 micky_ching
2013-12-18 6:53 ` Dan Carpenter [this message]
2013-12-18 9:26 ` [PATCH v4 0/2] mfd: rtsx: decrease driver size and add new device Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218065339.GB28413@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox