From: Lee Jones <lee.jones@linaro.org>
To: Laszlo Papp <lpapp@kde.org>
Cc: sameo@linux.intel.com, LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: Simple MFD driver example
Date: Wed, 18 Dec 2013 11:34:49 +0000 [thread overview]
Message-ID: <20131218113449.GF14274@lee--X1> (raw)
In-Reply-To: <CAOMwXhNMrnLEDUHrPqH1rgbFDgNPWmhCr2dPUNhdhfmdPTcGfg@mail.gmail.com>
> >> What you eventually see in hwmon is only a subset of all the features
> >> the IC provides. You may want to read this thread:
> >> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg536509.html
> >
> > Okay, so the best thing to do is send out the entire patch-set at
> > once, CC'ing each of the maintainers on every patch so we can all see
> > how this thing fits together.
>
> Well, I am not even sure currently where to head with the MFD bits and
> its children subdevices currently....
>
> I would appreciate any direction. Yesterday, I was told on IRC, I
> would need to switch from i2c to platform drivers for the hwmon and
> gpio parts, but looking at some existing mfd driver code and their
> children drivers, I do not see it like that.
>
> I have already sent out the gpio driver yesterday which works fine on
> its own: http://www.spinics.net/lists/kernel/msg1655805.html
This is going to need a lot of work.
Did you run the patch through `./scripts/checkpatch.pl` before
submitting?
> Could you please guide me into the right direction what I need to
> change once we have standalone drivers, and they should be glued
> together? I thought adding an abstraction with the mfd layer would be
> sufficient, but apparently, that is not enough.
>
> Practically speaking, I am confused since if I needed to change the
> existing drivers, that means I could potentially break the interface
> for the existing users if the drivers stop working on their own, but
> then again, I am such a newbie that I would greatly appreciate some
> pointers.
The MFD subsystem is quite simple to use. I'm taken aback that this is
your major stumbling block. Read though the mfd_add_device(s)() calls
to see what it expects. The rest is childs play.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-18 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOMwXhN5UfR=Y8V3i=A2zSCv7V9sRDd0Z+D1AQFahvRS-mV5Fw@mail.gmail.com>
2013-12-16 8:25 ` Simple MFD driver example Lee Jones
2013-12-16 14:00 ` Laszlo Papp
2013-12-16 15:05 ` Lee Jones
2013-12-16 16:39 ` Laszlo Papp
2013-12-16 16:48 ` Lee Jones
2013-12-17 17:09 ` Laszlo Papp
2013-12-18 9:16 ` Lee Jones
2013-12-18 10:42 ` Laszlo Papp
2013-12-18 11:12 ` Lee Jones
2013-12-18 11:17 ` Laszlo Papp
2013-12-18 11:34 ` Lee Jones [this message]
2013-12-18 11:49 ` Laszlo Papp
2013-12-18 11:59 ` Lee Jones
2013-12-18 12:01 ` Laszlo Papp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218113449.GF14274@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lpapp@kde.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox