From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755169Ab3LRPDw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Dec 2013 10:03:52 -0500
Received: from va3ehsobe004.messaging.microsoft.com ([216.32.180.14]:29341
	"EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754703Ab3LRPDu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Dec 2013 10:03:50 -0500
X-Forefront-Antispam-Report: CIP:165.204.84.222;KIP:(null);UIP:(null);IPV:NLI;H:atltwp02.amd.com;RD:none;EFVD:NLI
X-SpamScore: -3
X-BigFish: VPS-3(zz98dI1432I4015Izz1f42h2148h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah1fc6hzz1de098h8275bh1de097hz2dh839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah2222h224fh1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1fe8h1ff5h209eh2216h22d0h2336h1155h)
X-WSS-ID: 0MY0CBY-08-GRB-02
X-M-MSG: 
Date: Wed, 18 Dec 2013 22:46:03 +0800
From: Huang Rui <ray.huang@amd.com>
To: Roger Quadros <rogerq@ti.com>
CC: <gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>, <balbi@ti.com>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] usb: usbtest: Add timetout to simple_io()
Message-ID: <20131218144603.GA19091@hr-dev.amd.com>
References: <1387361411-15139-1-git-send-email-rogerq@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1387361411-15139-1-git-send-email-rogerq@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-OriginatorOrg: amd.com
X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn%
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Roger,

On Wed, Dec 18, 2013 at 03:40:10PM +0530, Roger Quadros wrote:
> Without a timetout some tests e.g. test_halt() can remain stuck forever.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/usb/misc/usbtest.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
> index b415282..6294e1b 100644
> --- a/drivers/usb/misc/usbtest.c
> +++ b/drivers/usb/misc/usbtest.c
> @@ -10,6 +10,7 @@
>  
>  #include <linux/usb.h>
>  
> +#define SIMPLE_IO_TIMEOUT	10000	/* in milliseconds */
>  

Only one question, how do you confirm the timeout value?

Thanks,
Rui

>  /*-------------------------------------------------------------------------*/
>  
> @@ -366,6 +367,7 @@ static int simple_io(
>  	int			max = urb->transfer_buffer_length;
>  	struct completion	completion;
>  	int			retval = 0;
> +	unsigned long		expire;
>  
>  	urb->context = &completion;
>  	while (retval == 0 && iterations-- > 0) {
> @@ -378,9 +380,15 @@ static int simple_io(
>  		if (retval != 0)
>  			break;
>  
> -		/* NOTE:  no timeouts; can't be broken out of by interrupt */
> -		wait_for_completion(&completion);
> -		retval = urb->status;
> +		expire = msecs_to_jiffies(SIMPLE_IO_TIMEOUT);
> +		if (!wait_for_completion_timeout(&completion, expire)) {
> +			usb_kill_urb(urb);
> +			retval = (urb->status == -ENOENT ?
> +				  -ETIMEDOUT : urb->status);
> +		} else {
> +			retval = urb->status;
> +		}
> +
>  		urb->dev = udev;
>  		if (retval == 0 && usb_pipein(urb->pipe))
>  			retval = simple_check_buf(tdev, urb);
> -- 
> 1.8.3.2
> 
>