From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755008Ab3LRO5Q (ORCPT ); Wed, 18 Dec 2013 09:57:16 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:49662 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754693Ab3LRO5O (ORCPT ); Wed, 18 Dec 2013 09:57:14 -0500 Date: Wed, 18 Dec 2013 09:56:02 -0500 From: Konrad Rzeszutek Wilk To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, mukesh.rathor@oracle.com, jbeulich@suse.com Subject: Re: [Xen-devel] [PATCH v11 11/12] xen/pvh: Disable PV code that does not work with PVH. Message-ID: <20131218145602.GA4934@phenom.dumpdata.com> References: <1387313503-31362-1-git-send-email-konrad.wilk@oracle.com> <1387313503-31362-12-git-send-email-konrad.wilk@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 18, 2013 at 02:19:28PM +0000, Stefano Stabellini wrote: > On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote: > > From: Mukesh Rathor > > > > As we do not have yet a mechanism for that. > > > > Signed-off-by: Mukesh Rathor > > Signed-off-by: Konrad Rzeszutek Wilk > > Even though we don't even compile cpu_hotplug on ARM yet, I don't like > this change because it affects ARM guests too. Perhaps then just #ifdef it with CONFIG_X86 for right now? > > Please add a note about ARM guests in the FIXME line. Good idea. Is the offline/online part working in ARM? Or is that it has not been tested? > > > > drivers/xen/cpu_hotplug.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c > > index cc6513a..cbb02af 100644 > > --- a/drivers/xen/cpu_hotplug.c > > +++ b/drivers/xen/cpu_hotplug.c > > @@ -4,6 +4,7 @@ > > > > #include > > #include > > +#include > > > > #include > > #include > > @@ -102,7 +103,8 @@ static int __init setup_vcpu_hotplug_event(void) > > static struct notifier_block xsn_cpu = { > > .notifier_call = setup_cpu_watcher }; > > > > - if (!xen_pv_domain()) > > + /* PVH TBD/FIXME: future work */ > > + if (!xen_pv_domain() || xen_feature(XENFEAT_auto_translated_physmap)) > > return -ENODEV; > > > > register_xenstore_notifier(&xsn_cpu); >