From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH] drivers: base: Add prototype declaration in memory.c
Date: Wed, 18 Dec 2013 07:34:51 -0800 [thread overview]
Message-ID: <20131218153451.GA22228@kroah.com> (raw)
In-Reply-To: <20131218063953.GA3180@rashika>
On Wed, Dec 18, 2013 at 12:09:53PM +0530, Rashika Kheria wrote:
> Add the prototype declaration of function memory_block_size_bytes() in
> memory.c.
>
> This eliminates the following warning in memory.c:
> drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
> drivers/base/memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index bece691..cfa03de 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -83,6 +83,7 @@ static void memory_block_release(struct device *dev)
> kfree(mem);
> }
>
> +unsigned long __weak memory_block_size_bytes(void);
> unsigned long __weak memory_block_size_bytes(void)
If this patch is the "solution" then something else is really wrong
here, please use your judgement to realize this...
greg k-h
next prev parent reply other threads:[~2013-12-18 15:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 6:39 [PATCH] drivers: base: Add prototype declaration in memory.c Rashika Kheria
2013-12-18 15:34 ` Greg Kroah-Hartman [this message]
2013-12-18 19:01 ` josh
2013-12-18 19:03 ` Greg Kroah-Hartman
2013-12-18 19:10 ` josh
2013-12-18 19:18 ` Greg Kroah-Hartman
2013-12-19 11:24 ` [PATCH v2] drivers: base: Add prototype declaration to the header file Rashika Kheria
2013-12-19 14:29 ` Josh Triplett
2013-12-19 18:13 ` Greg Kroah-Hartman
2013-12-19 18:41 ` Josh Triplett
2013-12-20 15:08 ` [PATCH v3] " Rashika Kheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218153451.GA22228@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox