[PATCH] drivers: base: Add prototype declaration in memory.c

[PATCH] drivers: base: Add prototype declaration in memory.c

[Rashika Kheria]

Add the prototype declaration of function memory_block_size_bytes() in
memory.c.

This eliminates the following warning in memory.c:
drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/base/memory.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index bece691..cfa03de 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -83,6 +83,7 @@ static void memory_block_release(struct device *dev)
 	kfree(mem);
 }
 
+unsigned long __weak memory_block_size_bytes(void);
 unsigned long __weak memory_block_size_bytes(void)
 {
 	return MIN_MEMORY_BLOCK_SIZE;
-- 
1.7.9.5

Re: [PATCH] drivers: base: Add prototype declaration in memory.c

[Greg Kroah-Hartman]

On Wed, Dec 18, 2013 at 12:09:53PM +0530, Rashika Kheria wrote:
> Add the prototype declaration of function memory_block_size_bytes() in
> memory.c.
> 
> This eliminates the following warning in memory.c:
> drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/base/memory.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index bece691..cfa03de 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -83,6 +83,7 @@ static void memory_block_release(struct device *dev)
>  	kfree(mem);
>  }
>  
> +unsigned long __weak memory_block_size_bytes(void);
>  unsigned long __weak memory_block_size_bytes(void)

If this patch is the "solution" then something else is really wrong
here, please use your judgement to realize this...

greg k-h

Re: [PATCH] drivers: base: Add prototype declaration in memory.c

[josh]

On Wed, Dec 18, 2013 at 07:34:51AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 18, 2013 at 12:09:53PM +0530, Rashika Kheria wrote:
> > Add the prototype declaration of function memory_block_size_bytes() in
> > memory.c.
> > 
> > This eliminates the following warning in memory.c:
> > drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> >  drivers/base/memory.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> > index bece691..cfa03de 100644
> > --- a/drivers/base/memory.c
> > +++ b/drivers/base/memory.c
> > @@ -83,6 +83,7 @@ static void memory_block_release(struct device *dev)
> >  	kfree(mem);
> >  }
> >  
> > +unsigned long __weak memory_block_size_bytes(void);
> >  unsigned long __weak memory_block_size_bytes(void)
> 
> If this patch is the "solution" then something else is really wrong
> here, please use your judgement to realize this...

It's a weak symbol provided and consumed within the same file, and then
overridden on a few random architectures.  It isn't currently prototyped
in any header file.  The other potential solution would be to add it to
an appropriate existing header or create a new one.  Any suggestions for
an appropriate existing header to prototype it in instead?

- Josh Triplett

Re: [PATCH] drivers: base: Add prototype declaration in memory.c

[Greg Kroah-Hartman]

On Wed, Dec 18, 2013 at 11:01:08AM -0800, josh@joshtriplett.org wrote:
> On Wed, Dec 18, 2013 at 07:34:51AM -0800, Greg Kroah-Hartman wrote:
> > On Wed, Dec 18, 2013 at 12:09:53PM +0530, Rashika Kheria wrote:
> > > Add the prototype declaration of function memory_block_size_bytes() in
> > > memory.c.
> > > 
> > > This eliminates the following warning in memory.c:
> > > drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> > > 
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > ---
> > >  drivers/base/memory.c |    1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> > > index bece691..cfa03de 100644
> > > --- a/drivers/base/memory.c
> > > +++ b/drivers/base/memory.c
> > > @@ -83,6 +83,7 @@ static void memory_block_release(struct device *dev)
> > >  	kfree(mem);
> > >  }
> > >  
> > > +unsigned long __weak memory_block_size_bytes(void);
> > >  unsigned long __weak memory_block_size_bytes(void)
> > 
> > If this patch is the "solution" then something else is really wrong
> > here, please use your judgement to realize this...
> 
> It's a weak symbol provided and consumed within the same file, and then
> overridden on a few random architectures.  It isn't currently prototyped
> in any header file.  The other potential solution would be to add it to
> an appropriate existing header or create a new one.  Any suggestions for
> an appropriate existing header to prototype it in instead?

device.h?

Re: [PATCH] drivers: base: Add prototype declaration in memory.c

[josh]

On Wed, Dec 18, 2013 at 11:03:44AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 18, 2013 at 11:01:08AM -0800, josh@joshtriplett.org wrote:
> > On Wed, Dec 18, 2013 at 07:34:51AM -0800, Greg Kroah-Hartman wrote:
> > > On Wed, Dec 18, 2013 at 12:09:53PM +0530, Rashika Kheria wrote:
> > > > Add the prototype declaration of function memory_block_size_bytes() in
> > > > memory.c.
> > > > 
> > > > This eliminates the following warning in memory.c:
> > > > drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> > > > 
> > > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > > ---
> > > >  drivers/base/memory.c |    1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> > > > index bece691..cfa03de 100644
> > > > --- a/drivers/base/memory.c
> > > > +++ b/drivers/base/memory.c
> > > > @@ -83,6 +83,7 @@ static void memory_block_release(struct device *dev)
> > > >  	kfree(mem);
> > > >  }
> > > >  
> > > > +unsigned long __weak memory_block_size_bytes(void);
> > > >  unsigned long __weak memory_block_size_bytes(void)
> > > 
> > > If this patch is the "solution" then something else is really wrong
> > > here, please use your judgement to realize this...
> > 
> > It's a weak symbol provided and consumed within the same file, and then
> > overridden on a few random architectures.  It isn't currently prototyped
> > in any header file.  The other potential solution would be to add it to
> > an appropriate existing header or create a new one.  Any suggestions for
> > an appropriate existing header to prototype it in instead?
> 
> device.h?

include/linux/device.h?  That would work, though it seems slightly
out of place there.

Would include/linux/memory.h work?

- Josh Triplett

Re: [PATCH] drivers: base: Add prototype declaration in memory.c

[Greg Kroah-Hartman]

On Wed, Dec 18, 2013 at 11:10:24AM -0800, josh@joshtriplett.org wrote:
> On Wed, Dec 18, 2013 at 11:03:44AM -0800, Greg Kroah-Hartman wrote:
> > On Wed, Dec 18, 2013 at 11:01:08AM -0800, josh@joshtriplett.org wrote:
> > > On Wed, Dec 18, 2013 at 07:34:51AM -0800, Greg Kroah-Hartman wrote:
> > > > On Wed, Dec 18, 2013 at 12:09:53PM +0530, Rashika Kheria wrote:
> > > > > Add the prototype declaration of function memory_block_size_bytes() in
> > > > > memory.c.
> > > > > 
> > > > > This eliminates the following warning in memory.c:
> > > > > drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> > > > > 
> > > > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > > > ---
> > > > >  drivers/base/memory.c |    1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > > 
> > > > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> > > > > index bece691..cfa03de 100644
> > > > > --- a/drivers/base/memory.c
> > > > > +++ b/drivers/base/memory.c
> > > > > @@ -83,6 +83,7 @@ static void memory_block_release(struct device *dev)
> > > > >  	kfree(mem);
> > > > >  }
> > > > >  
> > > > > +unsigned long __weak memory_block_size_bytes(void);
> > > > >  unsigned long __weak memory_block_size_bytes(void)
> > > > 
> > > > If this patch is the "solution" then something else is really wrong
> > > > here, please use your judgement to realize this...
> > > 
> > > It's a weak symbol provided and consumed within the same file, and then
> > > overridden on a few random architectures.  It isn't currently prototyped
> > > in any header file.  The other potential solution would be to add it to
> > > an appropriate existing header or create a new one.  Any suggestions for
> > > an appropriate existing header to prototype it in instead?
> > 
> > device.h?
> 
> include/linux/device.h?  That would work, though it seems slightly
> out of place there.
> 
> Would include/linux/memory.h work?

Sure, that's fine, I don't really care...

[PATCH v2] drivers: base: Add prototype declaration to the header file

[Rashika Kheria]

Add prototype declaration of function memory_block_size_bytes() to
the header file include/linux/memory.h.

This eliminates the following warning in memory.c:
drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

Changes since v1:
Incorrect Fix

 include/linux/memory.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/memory.h b/include/linux/memory.h
index 9a6bbf7..8c8f51c 100644
--- a/include/linux/memory.h
+++ b/include/linux/memory.h
@@ -35,6 +35,7 @@ struct memory_block {
 };
 
 int arch_get_memory_phys_device(unsigned long start_pfn);
+unsigned long __weak memory_block_size_bytes(void);	
 
 /* These states are exposed to userspace as text strings in sysfs */
 #define	MEM_ONLINE		(1<<0) /* exposed to userspace */
-- 
1.7.9.5

Re: [PATCH v2] drivers: base: Add prototype declaration to the header file

[Josh Triplett]

On Thu, Dec 19, 2013 at 04:54:57PM +0530, Rashika Kheria wrote:
> Add prototype declaration of function memory_block_size_bytes() to
> the header file include/linux/memory.h.
> 
> This eliminates the following warning in memory.c:
> drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  include/linux/memory.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 9a6bbf7..8c8f51c 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -35,6 +35,7 @@ struct memory_block {
>  };
>  
>  int arch_get_memory_phys_device(unsigned long start_pfn);
> +unsigned long __weak memory_block_size_bytes(void);	
>  
>  /* These states are exposed to userspace as text strings in sysfs */
>  #define	MEM_ONLINE		(1<<0) /* exposed to userspace */
> -- 
> 1.7.9.5
> 

Re: [PATCH v2] drivers: base: Add prototype declaration to the header file

[Greg Kroah-Hartman]

On Thu, Dec 19, 2013 at 04:54:57PM +0530, Rashika Kheria wrote:
> Add prototype declaration of function memory_block_size_bytes() to
> the header file include/linux/memory.h.
> 
> This eliminates the following warning in memory.c:
> drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Please ALWAYS run your patches through checkpatch.pl so a maintainer
doesn't have to write you an email like this reminding you to do that...

Josh, come on, you should have caught this as well, fix up your email
client to flag stuff like this easier...

greg k-h

Re: [PATCH v2] drivers: base: Add prototype declaration to the header file

[Josh Triplett]

On Thu, Dec 19, 2013 at 10:13:57AM -0800, Greg Kroah-Hartman wrote:
> On Thu, Dec 19, 2013 at 04:54:57PM +0530, Rashika Kheria wrote:
> > Add prototype declaration of function memory_block_size_bytes() to
> > the header file include/linux/memory.h.
> > 
> > This eliminates the following warning in memory.c:
> > drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> 
> Please ALWAYS run your patches through checkpatch.pl so a maintainer
> doesn't have to write you an email like this reminding you to do that...
> 
> Josh, come on, you should have caught this as well, fix up your email
> client to flag stuff like this easier...

If you're referring to the trailing whitespace on the line that was
added, I did indeed miss that.  Sorry about that.

I don't see any option in mutt that would make trailing whitespace
visible; if you know of one, I'd love to hear about it.  I do have vim
configured to highlight trailing whitespace, but I normally review
patches in mutt and then hit reply and use vim to provide a Reviewed-by
or line-by-line feedback if needed.  I should get in the habit of
reviewing patches in vim instead; if I had, I'd have caught this.

- Josh Triplett

[PATCH v3] drivers: base: Add prototype declaration to the header file

[Rashika Kheria]

Add prototype declaration of function memory_block_size_bytes() to
the header file include/linux/memory.h.

This eliminates the following warning in memory.c:
drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

Changes since v2:
Checkpatch error

 include/linux/memory.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/memory.h b/include/linux/memory.h
index 9a6bbf7..bb7384e 100644
--- a/include/linux/memory.h
+++ b/include/linux/memory.h
@@ -35,6 +35,7 @@ struct memory_block {
 };
 
 int arch_get_memory_phys_device(unsigned long start_pfn);
+unsigned long __weak memory_block_size_bytes(void);
 
 /* These states are exposed to userspace as text strings in sysfs */
 #define	MEM_ONLINE		(1<<0) /* exposed to userspace */
-- 
1.7.9.5