From: Vinod Koul <vinod.koul@intel.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
dmaengine@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c
Date: Wed, 18 Dec 2013 21:14:48 +0530 [thread overview]
Message-ID: <20131218154448.GD16227@intel.com> (raw)
In-Reply-To: <dba654dc34646dda2998dbf7b08d7ce3c160ff8c.1387188138.git.rashika.kheria@gmail.com>
On Mon, Dec 16, 2013 at 03:40:40PM +0530, Rashika Kheria wrote:
> Mark the functions ioat3_prep_xor_val(), ioat3_prep_pq_val() and
> ioat3_prep_pqxor_val() as static in dma_v3.c because they are not used
> outside this file.
>
> This eliminates the following warnings in dma_v3.c:
> drivers/dma/ioat/dma_v3.c:741:1: warning: no previous prototype for ‘ioat3_prep_xor_val’ [-Wmissing-prototypes]
> drivers/dma/ioat/dma_v3.c:1092:1: warning: no previous prototype for ‘ioat3_prep_pq_val’ [-Wmissing-prototypes]
> drivers/dma/ioat/dma_v3.c:1134:1: warning: no previous prototype for ‘ioat3_prep_pqxor_val’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
prev parent reply other threads:[~2013-12-18 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 10:10 [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Rashika Kheria
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
2013-12-16 10:21 ` Josh Triplett
2013-12-18 15:45 ` Vinod Koul
2013-12-16 10:21 ` [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Josh Triplett
2013-12-18 15:44 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218154448.GD16227@intel.com \
--to=vinod.koul@intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=josh@joshtriplett.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox