* [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c
@ 2013-12-16 10:10 Rashika Kheria
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rashika Kheria @ 2013-12-16 10:10 UTC (permalink / raw)
To: linux-kernel
Cc: Vinod Koul, Dan Williams, Dave Jiang, Bartlomiej Zolnierkiewicz,
Kyungmin Park, dmaengine, josh
Mark the functions ioat3_prep_xor_val(), ioat3_prep_pq_val() and
ioat3_prep_pqxor_val() as static in dma_v3.c because they are not used
outside this file.
This eliminates the following warnings in dma_v3.c:
drivers/dma/ioat/dma_v3.c:741:1: warning: no previous prototype for ‘ioat3_prep_xor_val’ [-Wmissing-prototypes]
drivers/dma/ioat/dma_v3.c:1092:1: warning: no previous prototype for ‘ioat3_prep_pq_val’ [-Wmissing-prototypes]
drivers/dma/ioat/dma_v3.c:1134:1: warning: no previous prototype for ‘ioat3_prep_pqxor_val’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/dma/ioat/dma_v3.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
index 820817e9..07038ca 100644
--- a/drivers/dma/ioat/dma_v3.c
+++ b/drivers/dma/ioat/dma_v3.c
@@ -737,7 +737,7 @@ ioat3_prep_xor(struct dma_chan *chan, dma_addr_t dest, dma_addr_t *src,
return __ioat3_prep_xor_lock(chan, NULL, dest, src, src_cnt, len, flags);
}
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
ioat3_prep_xor_val(struct dma_chan *chan, dma_addr_t *src,
unsigned int src_cnt, size_t len,
enum sum_check_flags *result, unsigned long flags)
@@ -1088,7 +1088,7 @@ ioat3_prep_pq(struct dma_chan *chan, dma_addr_t *dst, dma_addr_t *src,
}
}
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
ioat3_prep_pq_val(struct dma_chan *chan, dma_addr_t *pq, dma_addr_t *src,
unsigned int src_cnt, const unsigned char *scf, size_t len,
enum sum_check_flags *pqres, unsigned long flags)
@@ -1130,7 +1130,7 @@ ioat3_prep_pqxor(struct dma_chan *chan, dma_addr_t dst, dma_addr_t *src,
flags);
}
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
ioat3_prep_pqxor_val(struct dma_chan *chan, dma_addr_t *src,
unsigned int src_cnt, size_t len,
enum sum_check_flags *result, unsigned long flags)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c
2013-12-16 10:10 [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Rashika Kheria
@ 2013-12-16 10:14 ` Rashika Kheria
2013-12-16 10:21 ` Josh Triplett
2013-12-18 15:45 ` Vinod Koul
2013-12-16 10:21 ` [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Josh Triplett
2013-12-18 15:44 ` Vinod Koul
2 siblings, 2 replies; 6+ messages in thread
From: Rashika Kheria @ 2013-12-16 10:14 UTC (permalink / raw)
To: linux-kernel
Cc: Vinod Koul, Dan Williams, David S. Miller, Greg Kroah-Hartman,
Alexander Duyck, dmaengine, josh
Includes an appropriate header file dma_v2.h in ioat/dca.c because
functions ioat2_dca_init() and ioat3_dca_init() have their function
declarations in dma_v2.h.
This eliminates the following warning in ioat/dca.c:
drivers/dma/ioat/dca.c:410:22: warning: no previous prototype for ‘ioat2_dca_init’ [-Wmissing-prototypes]
drivers/dma/ioat/dca.c:624:22: warning: no previous prototype for ‘ioat3_dca_init’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/dma/ioat/dca.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ioat/dca.c b/drivers/dma/ioat/dca.c
index 9e84d5b..b158bba 100644
--- a/drivers/dma/ioat/dca.c
+++ b/drivers/dma/ioat/dca.c
@@ -35,6 +35,7 @@
#include "dma.h"
#include "registers.h"
+#include "dma_v2.h"
/*
* Bit 7 of a tag map entry is the "valid" bit, if it is set then bits 0:6
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
@ 2013-12-16 10:21 ` Josh Triplett
2013-12-18 15:45 ` Vinod Koul
1 sibling, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-16 10:21 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Vinod Koul, Dan Williams, David S. Miller,
Greg Kroah-Hartman, Alexander Duyck, dmaengine
On Mon, Dec 16, 2013 at 03:44:39PM +0530, Rashika Kheria wrote:
> Includes an appropriate header file dma_v2.h in ioat/dca.c because
> functions ioat2_dca_init() and ioat3_dca_init() have their function
> declarations in dma_v2.h.
>
> This eliminates the following warning in ioat/dca.c:
> drivers/dma/ioat/dca.c:410:22: warning: no previous prototype for ‘ioat2_dca_init’ [-Wmissing-prototypes]
> drivers/dma/ioat/dca.c:624:22: warning: no previous prototype for ‘ioat3_dca_init’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/dma/ioat/dca.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ioat/dca.c b/drivers/dma/ioat/dca.c
> index 9e84d5b..b158bba 100644
> --- a/drivers/dma/ioat/dca.c
> +++ b/drivers/dma/ioat/dca.c
> @@ -35,6 +35,7 @@
>
> #include "dma.h"
> #include "registers.h"
> +#include "dma_v2.h"
>
> /*
> * Bit 7 of a tag map entry is the "valid" bit, if it is set then bits 0:6
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
2013-12-16 10:21 ` Josh Triplett
@ 2013-12-18 15:45 ` Vinod Koul
1 sibling, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2013-12-18 15:45 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Dan Williams, David S. Miller, Greg Kroah-Hartman,
Alexander Duyck, dmaengine, josh
On Mon, Dec 16, 2013 at 03:44:39PM +0530, Rashika Kheria wrote:
> Includes an appropriate header file dma_v2.h in ioat/dca.c because
> functions ioat2_dca_init() and ioat3_dca_init() have their function
> declarations in dma_v2.h.
>
> This eliminates the following warning in ioat/dca.c:
> drivers/dma/ioat/dca.c:410:22: warning: no previous prototype for ‘ioat2_dca_init’ [-Wmissing-prototypes]
> drivers/dma/ioat/dca.c:624:22: warning: no previous prototype for ‘ioat3_dca_init’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
> ---
> drivers/dma/ioat/dca.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ioat/dca.c b/drivers/dma/ioat/dca.c
> index 9e84d5b..b158bba 100644
> --- a/drivers/dma/ioat/dca.c
> +++ b/drivers/dma/ioat/dca.c
> @@ -35,6 +35,7 @@
>
> #include "dma.h"
> #include "registers.h"
> +#include "dma_v2.h"
>
> /*
> * Bit 7 of a tag map entry is the "valid" bit, if it is set then bits 0:6
> --
> 1.7.9.5
>
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c
2013-12-16 10:10 [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Rashika Kheria
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
@ 2013-12-16 10:21 ` Josh Triplett
2013-12-18 15:44 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-16 10:21 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Vinod Koul, Dan Williams, Dave Jiang,
Bartlomiej Zolnierkiewicz, Kyungmin Park, dmaengine
On Mon, Dec 16, 2013 at 03:40:40PM +0530, Rashika Kheria wrote:
> Mark the functions ioat3_prep_xor_val(), ioat3_prep_pq_val() and
> ioat3_prep_pqxor_val() as static in dma_v3.c because they are not used
> outside this file.
>
> This eliminates the following warnings in dma_v3.c:
> drivers/dma/ioat/dma_v3.c:741:1: warning: no previous prototype for ‘ioat3_prep_xor_val’ [-Wmissing-prototypes]
> drivers/dma/ioat/dma_v3.c:1092:1: warning: no previous prototype for ‘ioat3_prep_pq_val’ [-Wmissing-prototypes]
> drivers/dma/ioat/dma_v3.c:1134:1: warning: no previous prototype for ‘ioat3_prep_pqxor_val’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/dma/ioat/dma_v3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
> index 820817e9..07038ca 100644
> --- a/drivers/dma/ioat/dma_v3.c
> +++ b/drivers/dma/ioat/dma_v3.c
> @@ -737,7 +737,7 @@ ioat3_prep_xor(struct dma_chan *chan, dma_addr_t dest, dma_addr_t *src,
> return __ioat3_prep_xor_lock(chan, NULL, dest, src, src_cnt, len, flags);
> }
>
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ioat3_prep_xor_val(struct dma_chan *chan, dma_addr_t *src,
> unsigned int src_cnt, size_t len,
> enum sum_check_flags *result, unsigned long flags)
> @@ -1088,7 +1088,7 @@ ioat3_prep_pq(struct dma_chan *chan, dma_addr_t *dst, dma_addr_t *src,
> }
> }
>
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ioat3_prep_pq_val(struct dma_chan *chan, dma_addr_t *pq, dma_addr_t *src,
> unsigned int src_cnt, const unsigned char *scf, size_t len,
> enum sum_check_flags *pqres, unsigned long flags)
> @@ -1130,7 +1130,7 @@ ioat3_prep_pqxor(struct dma_chan *chan, dma_addr_t dst, dma_addr_t *src,
> flags);
> }
>
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ioat3_prep_pqxor_val(struct dma_chan *chan, dma_addr_t *src,
> unsigned int src_cnt, size_t len,
> enum sum_check_flags *result, unsigned long flags)
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c
2013-12-16 10:10 [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Rashika Kheria
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
2013-12-16 10:21 ` [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Josh Triplett
@ 2013-12-18 15:44 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2013-12-18 15:44 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Dan Williams, Dave Jiang, Bartlomiej Zolnierkiewicz,
Kyungmin Park, dmaengine, josh
On Mon, Dec 16, 2013 at 03:40:40PM +0530, Rashika Kheria wrote:
> Mark the functions ioat3_prep_xor_val(), ioat3_prep_pq_val() and
> ioat3_prep_pqxor_val() as static in dma_v3.c because they are not used
> outside this file.
>
> This eliminates the following warnings in dma_v3.c:
> drivers/dma/ioat/dma_v3.c:741:1: warning: no previous prototype for ‘ioat3_prep_xor_val’ [-Wmissing-prototypes]
> drivers/dma/ioat/dma_v3.c:1092:1: warning: no previous prototype for ‘ioat3_prep_pq_val’ [-Wmissing-prototypes]
> drivers/dma/ioat/dma_v3.c:1134:1: warning: no previous prototype for ‘ioat3_prep_pqxor_val’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-18 16:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-16 10:10 [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Rashika Kheria
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
2013-12-16 10:21 ` Josh Triplett
2013-12-18 15:45 ` Vinod Koul
2013-12-16 10:21 ` [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Josh Triplett
2013-12-18 15:44 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox