From: Vinod Koul <vinod.koul@intel.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Duyck <alexander.h.duyck@intel.com>,
dmaengine@vger.kernel.org, josh@joshtriplett.org
Subject: Re: [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c
Date: Wed, 18 Dec 2013 21:15:16 +0530 [thread overview]
Message-ID: <20131218154516.GE16227@intel.com> (raw)
In-Reply-To: <855c6e216e86bed7b723c1a647491d9fab2ed77b.1387188138.git.rashika.kheria@gmail.com>
On Mon, Dec 16, 2013 at 03:44:39PM +0530, Rashika Kheria wrote:
> Includes an appropriate header file dma_v2.h in ioat/dca.c because
> functions ioat2_dca_init() and ioat3_dca_init() have their function
> declarations in dma_v2.h.
>
> This eliminates the following warning in ioat/dca.c:
> drivers/dma/ioat/dca.c:410:22: warning: no previous prototype for ‘ioat2_dca_init’ [-Wmissing-prototypes]
> drivers/dma/ioat/dca.c:624:22: warning: no previous prototype for ‘ioat3_dca_init’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
> ---
> drivers/dma/ioat/dca.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ioat/dca.c b/drivers/dma/ioat/dca.c
> index 9e84d5b..b158bba 100644
> --- a/drivers/dma/ioat/dca.c
> +++ b/drivers/dma/ioat/dca.c
> @@ -35,6 +35,7 @@
>
> #include "dma.h"
> #include "registers.h"
> +#include "dma_v2.h"
>
> /*
> * Bit 7 of a tag map entry is the "valid" bit, if it is set then bits 0:6
> --
> 1.7.9.5
>
--
next prev parent reply other threads:[~2013-12-18 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 10:10 [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Rashika Kheria
2013-12-16 10:14 ` [PATCH 2/2] drivers: dma: Include appropriate header file in dca.c Rashika Kheria
2013-12-16 10:21 ` Josh Triplett
2013-12-18 15:45 ` Vinod Koul [this message]
2013-12-16 10:21 ` [PATCH 1/2] drivers: dma: Mark functions as static in dma_v3.c Josh Triplett
2013-12-18 15:44 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218154516.GE16227@intel.com \
--to=vinod.koul@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox