From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755249Ab3LRQtR (ORCPT ); Wed, 18 Dec 2013 11:49:17 -0500 Received: from mga09.intel.com ([134.134.136.24]:20093 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752583Ab3LRQtP (ORCPT ); Wed, 18 Dec 2013 11:49:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,508,1384329600"; d="scan'208";a="454326447" Date: Wed, 18 Dec 2013 21:19:55 +0530 From: Vinod Koul To: "Chew, Chiau Ee" Cc: "Shevchenko, Andriy" , Viresh Kumar , Andy Shevchenko , "Williams, Dan J" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dma: dw: Add suspend and resume handling for PCI mode DW_DMAC. Message-ID: <20131218154955.GF16227@intel.com> References: <1386684373-24753-1-git-send-email-chiau.ee.chew@intel.com> <20131210101025.GF29580@intel.com> <1386676582.1871.137.camel@smile> <604BF5F4C5D71041942BC7E84ED659EA01520785@PGSMSX103.gar.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <604BF5F4C5D71041942BC7E84ED659EA01520785@PGSMSX103.gar.corp.intel.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2013 at 01:51:47PM +0530, Chew, Chiau Ee wrote: > Vinod, Please do *NOT* top post Please fix your MUA to wrap lines with 80chars. I have fix below to make it readble... > As mentioned by Andy, we are using *_noirq verion of suspend/resume PM > callback whereby the callbacks would be executed after IRQ handlers have been > disabled. If using SET_SYSTEM_SLEEP_PM_OPS, it would be the normal > suspend/resume PM callback. Looking at the Desginware DMAC platform code > (drivers/dma/dw/platform.c), it is using the *_noirq suspend/resume PM > callback. Is it advisable to use the normal suspend/resume PM callback instead > of *_noirq suspend/PM callback? i dont see a reason why we need the noirq versions -- ~Vinod > > Thanks, > Chiau Ee > > -----Original Message----- > From: Shevchenko, Andriy > Sent: Tuesday, December 10, 2013 7:57 PM > To: Koul, Vinod > Cc: Chew, Chiau Ee; Viresh Kumar; Andy Shevchenko; Williams, Dan J; dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] dma: dw: Add suspend and resume handling for PCI mode DW_DMAC. > > On Tue, 2013-12-10 at 15:40 +0530, Vinod Koul wrote: > > On Tue, Dec 10, 2013 at 10:06:13PM +0800, Chew Chiau Ee wrote: > > > From: Chew, Chiau Ee > > > > > > This is to disable/enable DW_DMAC hw during suspend/resume. > > > > > > Signed-off-by: Chew, Chiau Ee > > > Acked-by: Andy Shevchenko > > > --- > > > drivers/dma/dw/pci.c | 33 +++++++++++++++++++++++++++++++++ > > > 1 files changed, 33 insertions(+), 0 deletions(-) > > > > > > diff --git a/drivers/dma/dw/pci.c b/drivers/dma/dw/pci.c index > > > e89fc24..97bc3a2 100644 > > > --- a/drivers/dma/dw/pci.c > > > +++ b/drivers/dma/dw/pci.c > > > @@ -75,6 +75,36 @@ static void dw_pci_remove(struct pci_dev *pdev) > > > dev_warn(&pdev->dev, "can't remove device properly: %d\n", ret); > > > } > > > > > > +#ifdef CONFIG_PM_SLEEP > > > + > > > +static int dw_pci_suspend_noirq(struct device *dev) { > > > + struct pci_dev *pci = to_pci_dev(dev); > > > + struct dw_dma_chip *chip = pci_get_drvdata(pci); > > > + > > > + return dw_dma_suspend(chip); > > > +}; > > > + > > > +static int dw_pci_resume_noirq(struct device *dev) { > > > + struct pci_dev *pci = to_pci_dev(dev); > > > + struct dw_dma_chip *chip = pci_get_drvdata(pci); > > > + > > > + return dw_dma_resume(chip); > > > +}; > > > + > > > +#else /* !CONFIG_PM_SLEEP */ > > > + > > > +#define dw_pci_suspend_noirq NULL > > > +#define dw_pci_resume_noirq NULL > > > + > > > +#endif /* !CONFIG_PM_SLEEP */ > > How about SET_SYSTEM_SLEEP_PM_OPS instead? > > So, we are using *_noirq versions of the functions here. What happened when we switch to normal ones? Any side effects? > > > > > -- > > ~Vinod > > > + > > > +static const struct dev_pm_ops dw_pci_dev_pm_ops = { > > > + .suspend_noirq = dw_pci_suspend_noirq, > > > + .resume_noirq = dw_pci_resume_noirq, }; > > > + > > > static DEFINE_PCI_DEVICE_TABLE(dw_pci_id_table) = { > > > /* Medfield */ > > > { PCI_VDEVICE(INTEL, 0x0827), (kernel_ulong_t)&dw_pci_pdata }, @@ > > > -92,6 +122,9 @@ static struct pci_driver dw_pci_driver = { > > > .id_table = dw_pci_id_table, > > > .probe = dw_pci_probe, > > > .remove = dw_pci_remove, > > > + .driver = { > > > + .pm = &dw_pci_dev_pm_ops, > > > + }, > > > }; > > > > > > module_pci_driver(dw_pci_driver); > > > -- > > > 1.7.4.4 > > > > > > > -- > Andy Shevchenko Intel Finland Oy --