* [PATCH 1/1] dmaengine: fix incorrect kernel-doc comment for struct dma_slave_config
@ 2013-12-16 8:12 Alexander Popov
2013-12-18 16:11 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Popov @ 2013-12-16 8:12 UTC (permalink / raw)
To: Gerhard Sittig, Dan Williams, Vinod Koul, Lars-Peter Clausen,
Arnd Bergmann, Anatolij Gustschin, Alexander Popov, dmaengine,
linux-kernel
The 'direction' member of 'struct dma_slave_config' is of data
type 'enum dma_transfer_direction', so update the kernel-doc comment
for 'struct dma_slave_config' to refer to appropriate values.
Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
---
include/linux/dmaengine.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 41cf0c3..bd6b882 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -305,9 +305,8 @@ enum dma_slave_buswidth {
/**
* struct dma_slave_config - dma slave channel runtime config
* @direction: whether the data shall go in or out on this slave
- * channel, right now. DMA_TO_DEVICE and DMA_FROM_DEVICE are
- * legal values, DMA_BIDIRECTIONAL is not acceptable since we
- * need to differentiate source and target addresses.
+ * channel, right now. DMA_MEM_TO_DEV and DMA_DEV_TO_MEM are
+ * legal values.
* @src_addr: this is the physical address where DMA slave data
* should be read (RX), if the source is memory this argument is
* ignored.
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] dmaengine: fix incorrect kernel-doc comment for struct dma_slave_config
2013-12-16 8:12 [PATCH 1/1] dmaengine: fix incorrect kernel-doc comment for struct dma_slave_config Alexander Popov
@ 2013-12-18 16:11 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2013-12-18 16:11 UTC (permalink / raw)
To: Alexander Popov
Cc: Gerhard Sittig, Dan Williams, Lars-Peter Clausen, Arnd Bergmann,
Anatolij Gustschin, dmaengine, linux-kernel
On Mon, Dec 16, 2013 at 12:12:17PM +0400, Alexander Popov wrote:
> The 'direction' member of 'struct dma_slave_config' is of data
> type 'enum dma_transfer_direction', so update the kernel-doc comment
> for 'struct dma_slave_config' to refer to appropriate values.
>
> Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
Applied, thanks
--
~Vinod
> ---
> include/linux/dmaengine.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 41cf0c3..bd6b882 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -305,9 +305,8 @@ enum dma_slave_buswidth {
> /**
> * struct dma_slave_config - dma slave channel runtime config
> * @direction: whether the data shall go in or out on this slave
> - * channel, right now. DMA_TO_DEVICE and DMA_FROM_DEVICE are
> - * legal values, DMA_BIDIRECTIONAL is not acceptable since we
> - * need to differentiate source and target addresses.
> + * channel, right now. DMA_MEM_TO_DEV and DMA_DEV_TO_MEM are
> + * legal values.
> * @src_addr: this is the physical address where DMA slave data
> * should be read (RX), if the source is memory this argument is
> * ignored.
> --
> 1.8.4.2
>
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-18 17:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-16 8:12 [PATCH 1/1] dmaengine: fix incorrect kernel-doc comment for struct dma_slave_config Alexander Popov
2013-12-18 16:11 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox