From: Vinod Koul <vinod.koul@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dma: pl08x: allow zero slave channels
Date: Wed, 18 Dec 2013 21:58:52 +0530 [thread overview]
Message-ID: <20131218162852.GM16227@intel.com> (raw)
In-Reply-To: <1386976583-31395-1-git-send-email-linus.walleij@linaro.org>
On Sat, Dec 14, 2013 at 12:16:23AM +0100, Linus Walleij wrote:
> It might happen that a platform wants to use its DMA engine for
> memcpy only, and then we have zero slave channels to initialize,
> so allow the slave initialization to return zero.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, this one
--
~Vinod
> ---
> drivers/dma/amba-pl08x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index ec4ee5c1fe9d..f68f1c1d560b 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -2167,7 +2167,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
> /* Register slave channels */
> ret = pl08x_dma_init_virtual_channels(pl08x, &pl08x->slave,
> pl08x->pd->num_slave_channels, true);
> - if (ret <= 0) {
> + if (ret < 0) {
> dev_warn(&pl08x->adev->dev,
> "%s failed to enumerate slave channels - %d\n",
> __func__, ret);
> --
> 1.8.3.1
>
--
prev parent reply other threads:[~2013-12-18 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 23:16 [PATCH 2/2] dma: pl08x: allow zero slave channels Linus Walleij
2013-12-18 16:28 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218162852.GM16227@intel.com \
--to=vinod.koul@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox