From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755798Ab3LRSj0 (ORCPT ); Wed, 18 Dec 2013 13:39:26 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55553 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754923Ab3LRSjY (ORCPT ); Wed, 18 Dec 2013 13:39:24 -0500 Date: Wed, 18 Dec 2013 10:39:19 -0800 From: josh@joshtriplett.org To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, "Nicholas A. Bellinger" , Hannes Reinecke , Andy Grover , Joern Engel , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH 3/4] drivers: target: Mark functions as static in tcm_loop.c Message-ID: <20131218183919.GC24229@cloud> References: <1a63603bc5ff05147c419a301d59b135cd0c8406.1387390091.git.rashika.kheria@gmail.com> <6d957ed9181ac274d13385db204db100b0ef8416.1387390091.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6d957ed9181ac274d13385db204db100b0ef8416.1387390091.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 19, 2013 at 12:02:54AM +0530, Rashika Kheria wrote: > Mark functions tcm_loop_make_naa_tpg(), tcm_loop_drop_naa_tpg(), > tcm_loop_make_scsi_hba() and tcm_loop_drop_scsi_hba() as static in > loopback/tcm_loop.c because they are not used outside this file. > > This eliminates the following warning in loopback/tcm_loop.c: > drivers/target/loopback/tcm_loop.c:1231:25: warning: no previous prototype for ‘tcm_loop_make_naa_tpg’ [-Wmissing-prototypes] > drivers/target/loopback/tcm_loop.c:1276:6: warning: no previous prototype for ‘tcm_loop_drop_naa_tpg’ [-Wmissing-prototypes] > drivers/target/loopback/tcm_loop.c:1308:16: warning: no previous prototype for ‘tcm_loop_make_scsi_hba’ [-Wmissing-prototypes] > drivers/target/loopback/tcm_loop.c:1378:6: warning: no previous prototype for ‘tcm_loop_drop_scsi_hba’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/target/loopback/tcm_loop.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c > index 1b41e67..763ee45 100644 > --- a/drivers/target/loopback/tcm_loop.c > +++ b/drivers/target/loopback/tcm_loop.c > @@ -1228,7 +1228,7 @@ static struct configfs_attribute *tcm_loop_tpg_attrs[] = { > > /* Start items for tcm_loop_naa_cit */ > > -struct se_portal_group *tcm_loop_make_naa_tpg( > +static struct se_portal_group *tcm_loop_make_naa_tpg( > struct se_wwn *wwn, > struct config_group *group, > const char *name) > @@ -1273,7 +1273,7 @@ struct se_portal_group *tcm_loop_make_naa_tpg( > return &tl_tpg->tl_se_tpg; > } > > -void tcm_loop_drop_naa_tpg( > +static void tcm_loop_drop_naa_tpg( > struct se_portal_group *se_tpg) > { > struct se_wwn *wwn = se_tpg->se_tpg_wwn; > @@ -1305,7 +1305,7 @@ void tcm_loop_drop_naa_tpg( > > /* Start items for tcm_loop_cit */ > > -struct se_wwn *tcm_loop_make_scsi_hba( > +static struct se_wwn *tcm_loop_make_scsi_hba( > struct target_fabric_configfs *tf, > struct config_group *group, > const char *name) > @@ -1375,7 +1375,7 @@ out: > return ERR_PTR(ret); > } > > -void tcm_loop_drop_scsi_hba( > +static void tcm_loop_drop_scsi_hba( > struct se_wwn *wwn) > { > struct tcm_loop_hba *tl_hba = container_of(wwn, > -- > 1.7.9.5 >