From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753349Ab3LSIxQ (ORCPT ); Thu, 19 Dec 2013 03:53:16 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:46702 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148Ab3LSIxN (ORCPT ); Thu, 19 Dec 2013 03:53:13 -0500 Date: Thu, 19 Dec 2013 08:53:08 +0000 From: Lee Jones To: Sebastian Andrzej Siewior Cc: Jonathan Cameron , Dmitry Torokhov , Samuel Ortiz , Zubair Lutfullah , Felipe Balbi , linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mfd: ti_am335x_tscadc: make am335x_tsc_se_update() local Message-ID: <20131219085308.GF2621@lee--X1> References: <1387385577-24447-1-git-send-email-bigeasy@linutronix.de> <1387385577-24447-3-git-send-email-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1387385577-24447-3-git-send-email-bigeasy@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > since the "recent" changes, am335x_tsc_se_update() has no longer any > users outside of this file so make it local. Please use formatting dictated by the subsystem when providing patches. For MFD we capitalise the first word after 'mfd: : ' and the same for the first word in the commit body. Patch looks okay, I'd prefer to take the set in one go. Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog