From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 13/13] drivers: block: Remove unused function in genl_magic_func.h
Date: Thu, 19 Dec 2013 01:59:25 -0800 [thread overview]
Message-ID: <20131219095925.GA20075@leaf> (raw)
In-Reply-To: <6ad65a8d9a9f0467f2ad080e0a4db7ea49142371.1387445397.git.rashika.kheria@gmail.com>
On Thu, Dec 19, 2013 at 03:22:10PM +0530, Rashika Kheria wrote:
> Remove unused function CONCAT_(GENL_MAGIC_FAMILY, _genl_cmd_to_str) in
> include/linux/genl_magic_func.h.
>
> This eliminates the following warning in
> include/linux/genl_magic_func.h:
> include/linux/genl_magic_func.h:221:1: warning: no previous prototype for ‘drbd_genl_cmd_to_str’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> include/linux/genl_magic_func.h | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/include/linux/genl_magic_func.h b/include/linux/genl_magic_func.h
> index c0894dd..0456ad8 100644
> --- a/include/linux/genl_magic_func.h
> +++ b/include/linux/genl_magic_func.h
> @@ -214,22 +214,6 @@ static int s_name ## _from_attrs_for_change(struct s_name *s, \
> #undef GENL_struct
> #define GENL_struct(tag_name, tag_number, s_name, s_fields)
>
> -/*
> - * Magic: define op number to op name mapping {{{1
> - * {{{2
> - */
> -const char *CONCAT_(GENL_MAGIC_FAMILY, _genl_cmd_to_str)(__u8 cmd)
> -{
> - switch (cmd) {
> -#undef GENL_op
> -#define GENL_op(op_name, op_num, handler, tla_list) \
> - case op_num: return #op_name;
> -#include GENL_MAGIC_INCLUDE_FILE
> - default:
> - return "unknown";
> - }
> -}
> -
> #ifdef __KERNEL__
> #include <linux/stringify.h>
> /*
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-19 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 9:32 [PATCH 01/13] drivers: block: Mark the functions as static in skd_main.c Rashika Kheria
2013-12-19 9:33 ` [PATCH 02/13] drivers: block: Remove unused function drbd_bm_write_lazy() in drbd_bitmap.c Rashika Kheria
2013-12-19 9:34 ` [PATCH 03/13] drivers: block: Mark function seq_printf_with_thousands_grouping() as static in drbd_proc.c Rashika Kheria
2013-12-19 9:36 ` [PATCH 04/13] drivers: block: Mark the function as static in drbd_worker.c Rashika Kheria
2013-12-19 9:37 ` [PATCH 05/13] drivers: block: Move prototype declaration to appropriate header file from drbd_main.c Rashika Kheria
2013-12-19 9:41 ` [PATCH 06/13] drivers: block: Mark functions as static in drbd_receiver.c Rashika Kheria
2013-12-19 9:42 ` [PATCH 07/13] drivers: block: Mark functions as static in drbd_req.c Rashika Kheria
2013-12-19 9:43 ` [PATCH 08/13] drivers: block: Mark function as static in drbd_actlog.c Rashika Kheria
2013-12-19 9:45 ` [PATCH 09/13] drivers: block: Move prototype declaration of function tl_abort_disk_io() to appropriate header file from drbd_state.c Rashika Kheria
2013-12-19 9:46 ` [PATCH 10/13] drivers: block: Mark functions as static in drbd_main.c Rashika Kheria
2013-12-19 9:47 ` [PATCH 11/13] drivers: block: Mark functions as static in drbd_nl.c Rashika Kheria
2013-12-19 9:48 ` [PATCH 12/13] drivers: block: Mark function as static in drbd_state.c Rashika Kheria
2013-12-19 9:52 ` [PATCH 13/13] drivers: block: Remove unused function in genl_magic_func.h Rashika Kheria
2013-12-19 9:59 ` Josh Triplett [this message]
2013-12-19 15:07 ` [PATCH 01/13] drivers: block: Mark the functions as static in skd_main.c Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219095925.GA20075@leaf \
--to=josh@joshtriplett.org \
--cc=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).