Re: [PATCH] drivers: pci: Add prototype declarations of function in appropriate header

Josh Triplett
2013-12-19T14:28:58Z

On Thu, Dec 19, 2013 at 04:23:12PM +0530, Rashika Kheria wrote:
> Add prototype declarations of functions arch_msi_mask_irq() and
> arch_msix_mask_irq() to header file include/linux/msi.h.
>
> This eliminates the following warning in msi.c:
> drivers/pci/msi.c:202:12: warning: no previous prototype for ‘arch_msi_mask_irq’ [-Wmissing-prototypes]
> drivers/pci/msi.c:232:12: warning: no previous prototype for ‘arch_msix_mask_irq’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> include/linux/msi.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/msi.h b/include/linux/msi.h
> index 009b024..63b7d14 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -66,6 +66,8 @@ void default_teardown_msi_irqs(struct pci_dev *dev);
> void default_restore_msi_irqs(struct pci_dev *dev, int irq);
> u32 default_msi_mask_irq(struct msi_desc *desc, u32 mask, u32 flag);
> u32 default_msix_mask_irq(struct msi_desc *desc, u32 flag);
> +u32 arch_msi_mask_irq(struct msi_desc *desc, u32 mask, u32 flag);
> +u32 arch_msix_mask_irq(struct msi_desc *desc, u32 flag);
>
> struct msi_chip {
> struct module *owner;
> --
> 1.7.9.5
>