From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756516Ab3LSMF0 (ORCPT ); Thu, 19 Dec 2013 07:05:26 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:49589 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756490Ab3LSMFR (ORCPT ); Thu, 19 Dec 2013 07:05:17 -0500 Date: Thu, 19 Dec 2013 04:05:16 -0800 From: Christoph Hellwig To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, Tejun Heo , Andrew Morton , Oleg Nesterov , Arjan van de Ven , Dan Williams Subject: Re: [PATCH] closures: move to lib/ Message-ID: <20131219120516.GA26089@infradead.org> References: <1387416594-23930-1-git-send-email-kmo@daterainc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387416594-23930-1-git-send-email-kmo@daterainc.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote: > the closure code was never intended to be bcache specific - hopefully it can be > useful elsewhere in the kernel. They are not. They aren't closures in the CS sense, and they are an ugly mess. Please work on removing them instead.