From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 3/6] perf tools: Get rid of a duplicate va_end()
Date: Thu, 19 Dec 2013 10:32:13 -0300 [thread overview]
Message-ID: <20131219133213.GL4819@ghostprotocols.net> (raw)
In-Reply-To: <1387436411-20160-4-git-send-email-namhyung@kernel.org>
Em Thu, Dec 19, 2013 at 04:00:08PM +0900, Namhyung Kim escreveu:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> The va_end() in _eprintf() should be removed since the caller also
> invokes va_end().
Thanks, applied.
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/util/debug.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c
> index 8640a9121e72..299b55586502 100644
> --- a/tools/perf/util/debug.c
> +++ b/tools/perf/util/debug.c
> @@ -25,7 +25,6 @@ static int _eprintf(int level, const char *fmt, va_list args)
> ui_helpline__vshow(fmt, args);
> else
> ret = vfprintf(stderr, fmt, args);
> - va_end(args);
> }
>
> return ret;
> --
> 1.7.11.7
next prev parent reply other threads:[~2013-12-19 13:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 7:00 [PATCHSET 0/6] perf tools: A couple of TUI improvements Namhyung Kim
2013-12-19 7:00 ` [PATCH 1/6] perf report: Use pr_*() functions if possible Namhyung Kim
2013-12-19 13:30 ` Arnaldo Carvalho de Melo
2013-12-20 1:32 ` Namhyung Kim
2013-12-19 13:31 ` Jiri Olsa
2013-12-20 1:36 ` Namhyung Kim
2013-12-19 7:00 ` [PATCH 2/6] perf tools: Introduce struct perf_log Namhyung Kim
2013-12-19 13:28 ` Arnaldo Carvalho de Melo
2013-12-20 1:28 ` Namhyung Kim
2013-12-19 7:00 ` [PATCH 3/6] perf tools: Get rid of a duplicate va_end() Namhyung Kim
2013-12-19 13:32 ` Jiri Olsa
2013-12-19 13:32 ` Arnaldo Carvalho de Melo [this message]
2014-01-12 18:32 ` [tip:perf/core] perf tools: Get rid of a duplicate va_end() in error reporting routine tip-bot for Namhyung Kim
2013-12-19 7:00 ` [PATCH 4/6] perf tools: Save message when pr_*() was called Namhyung Kim
2013-12-19 7:00 ` [PATCH 5/6] perf ui/tui: Implement log window Namhyung Kim
2013-12-19 7:00 ` [PATCH 6/6] perf ui/tui: Implement header window Namhyung Kim
2013-12-19 12:14 ` [PATCHSET 0/6] perf tools: A couple of TUI improvements Ingo Molnar
2013-12-20 1:20 ` Namhyung Kim
2013-12-19 13:39 ` Jiri Olsa
2013-12-19 15:51 ` Ingo Molnar
2013-12-19 15:53 ` Ingo Molnar
2013-12-20 1:21 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219133213.GL4819@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox