public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] drivers: base: Add prototype declaration to the header file
Date: Thu, 19 Dec 2013 06:29:31 -0800	[thread overview]
Message-ID: <20131219142930.GB20678@leaf> (raw)
In-Reply-To: <1387452297-28836-1-git-send-email-rashika.kheria@gmail.com>

On Thu, Dec 19, 2013 at 04:54:57PM +0530, Rashika Kheria wrote:
> Add prototype declaration of function memory_block_size_bytes() to
> the header file include/linux/memory.h.
> 
> This eliminates the following warning in memory.c:
> drivers/base/memory.c:87:1: warning: no previous prototype for ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  include/linux/memory.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 9a6bbf7..8c8f51c 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -35,6 +35,7 @@ struct memory_block {
>  };
>  
>  int arch_get_memory_phys_device(unsigned long start_pfn);
> +unsigned long __weak memory_block_size_bytes(void);	
>  
>  /* These states are exposed to userspace as text strings in sysfs */
>  #define	MEM_ONLINE		(1<<0) /* exposed to userspace */
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2013-12-19 14:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18  6:39 [PATCH] drivers: base: Add prototype declaration in memory.c Rashika Kheria
2013-12-18 15:34 ` Greg Kroah-Hartman
2013-12-18 19:01   ` josh
2013-12-18 19:03     ` Greg Kroah-Hartman
2013-12-18 19:10       ` josh
2013-12-18 19:18         ` Greg Kroah-Hartman
2013-12-19 11:24 ` [PATCH v2] drivers: base: Add prototype declaration to the header file Rashika Kheria
2013-12-19 14:29   ` Josh Triplett [this message]
2013-12-19 18:13   ` Greg Kroah-Hartman
2013-12-19 18:41     ` Josh Triplett
2013-12-20 15:08 ` [PATCH v3] " Rashika Kheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131219142930.GB20678@leaf \
    --to=josh@joshtriplett.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox