From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kent Overstreet <kmo@daterainc.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] closures: move to lib/
Date: Thu, 19 Dec 2013 10:27:01 -0500 [thread overview]
Message-ID: <20131219152701.GC16994@htj.dyndns.org> (raw)
In-Reply-To: <20131219120516.GA26089@infradead.org>
Hello,
On Thu, Dec 19, 2013 at 04:05:16AM -0800, Christoph Hellwig wrote:
> On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote:
> > the closure code was never intended to be bcache specific - hopefully it can be
> > useful elsewhere in the kernel.
>
> They are not. They aren't closures in the CS sense, and they are an
> ugly mess. Please work on removing them instead.
I pretty much agree with Christoph here. Compared to all other
generic utilities we have, the proposed mechanism is giant in its
conceptual complexity. This is a lot worse than semaphores. I
personally think inclusion of it in the upstream kernel at all was a
bad idea.
Nacked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2013-12-19 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 1:29 [PATCH] closures: move to lib/ Kent Overstreet
2013-12-19 1:34 ` Dan Williams
2013-12-19 1:37 ` Kent Overstreet
2013-12-19 12:05 ` Christoph Hellwig
2013-12-19 12:18 ` Kent Overstreet
2013-12-19 12:19 ` Christoph Hellwig
2013-12-19 12:21 ` Kent Overstreet
2013-12-22 19:30 ` Christoph Hellwig
2013-12-19 15:27 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219152701.GC16994@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox