From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, eranian@google.com,
dsahern@gmail.com, adrian.hunter@intel.com, mingo@redhat.com,
paulus@samba.org, a.p.zijlstra@chello.nl,
Pekka Enberg <penberg@iki.fi>
Subject: Re: [PATCH 0/4] Add support of guest user space symbols for perf kvm command.
Date: Thu, 19 Dec 2013 16:34:53 +0100 [thread overview]
Message-ID: <20131219153453.GA20044@gmail.com> (raw)
In-Reply-To: <20131219141232.GM4819@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Thu, Dec 19, 2013 at 05:54:50PM -0500, Dongsheng Yang escreveu:
> > Hi all,
> > This patch add support of guest user space symbols for perf kvm command.
>
> Cool stuff! Please see some comments on the patches, with requests for
> possible patch splits and better changeset comments.
>
> > Example:
> > # perf kvm --guestmount /tmp/guestmount/ top
> > Samples: 1K of event 'cycles', Event count (approx.): 259112905
Btw., having to specify a '--guestmount /tmp/guestmount/' just to
achieve a natural feature (proper guest symbol resolution) is a poor
user interface, obviously.
Is there perhaps a predictable pattern as to where qemu (or libvirt)
puts a user's guest mounts, or some other discovery method?
If yes then it would be possible to automatically look for that
pattern, and use the guest filesystem when it's available, without the
user having to manually configure the path.
( Ideally we'd have kernel help for discovering this, but last time I
raised that with the KVM folks there was resistence. )
Thanks,
Ingo
next prev parent reply other threads:[~2013-12-19 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 22:54 [PATCH 0/4] Add support of guest user space symbols for perf kvm command Dongsheng Yang
2013-12-19 14:12 ` Arnaldo Carvalho de Melo
2013-12-19 15:34 ` Ingo Molnar [this message]
2013-12-19 16:28 ` David Ahern
2013-12-19 22:54 ` [PATCH 1/4] perf tools: Add support of guest in synthesize_threads Dongsheng Yang
2013-12-19 14:21 ` Arnaldo Carvalho de Melo
2013-12-19 22:54 ` [PATCH 2/4] perf tools: Add support for PERF_RECORD_MISC_GUEST_USER in thread__find_addr_map() Dongsheng Yang
2013-12-19 22:54 ` [PATCH 3/4] perf tools: Add support of user space symbols for guest in perf kvm top Dongsheng Yang
2013-12-19 22:54 ` [PATCH 4/4] perf tools: Add support of user space symbols for guest in perf kvm record Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219153453.GA20044@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=penberg@iki.fi \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).