Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Dec 19, 2013 at 10:11:45PM +0530, Rashika Kheria wrote:
> On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
> >> Include appropriate header file include/linux/usb/otg.h in core/hcd.c
> >> because function usb_bus_start_enum() has its prototype declaration in
> >> include/linux/usb/otg.h.
> >>
> >> This eliminates the following warning in core/hcd.c:
> >> drivers/usb/core/hcd.c:2295:5: warning: no previous prototype for ‘usb_bus_start_enum’ [-Wmissing-prototypes]
> >
> > What is generating this warning?  I don't see it here on my machines,
> > nor do I see any of the other warnings you have fixed in this series.
> > How do I duplicate them?
> >
> > thanks,
> >
> > greg k-h
> 
> Hi Greg,
> 
> These warning are non-default GCC warnings. These can be seen either
> by adding W=1 while running make (i.e. make W=1) or adding
> -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.

By default, we don't care about 'W=1' warnings, as no one sees them, and
they don't matter.

Now if you were to see these issues with 'sparse' or just a "normal"
build, then that might be worth fixing up.

greg k-h