From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756330Ab3LSUmJ (ORCPT ); Thu, 19 Dec 2013 15:42:09 -0500 Received: from kanga.kvack.org ([205.233.56.17]:54179 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755958Ab3LSUmH (ORCPT ); Thu, 19 Dec 2013 15:42:07 -0500 Date: Thu, 19 Dec 2013 15:42:06 -0500 From: Benjamin LaHaise To: Linus Torvalds Cc: Kent Overstreet , Dave Jones , Linux Kernel , linux-mm , Christoph Lameter , Al Viro Subject: Re: bad page state in 3.13-rc4 Message-ID: <20131219204206.GC10905@kvack.org> References: <20131219181134.GC25385@kmo-pixel> <20131219182920.GG30640@kvack.org> <20131219192621.GA9228@kvack.org> <20131219195352.GB9228@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 20, 2013 at 05:31:29AM +0900, Linus Torvalds wrote: > On Fri, Dec 20, 2013 at 5:11 AM, Linus Torvalds > wrote: > > > > So here's the same patch, but with stuff moved around a bit, and the > > "oops, couldn't create page" part fixed. > > > > Bit it's still totally and entirely untested. > > Btw, I think this actually fixes a bug, in that it doesn't leak the > page reference count if the do_mmap_pgoff() call fails. > > That said, that looks like just a memory leak, not explaining the > problem Dave sees. And maybe I'm missing something. > > And no, I still haven't actually tested this at all. Is there an aio > tester that is worth trying? There are a few tests in the libaio source, some in xfstests and fio, and a few I've got sitting around. To specifically exercise the page migration code path, there's a test at http://www.kvack.org/~bcrl/aio-numa-test.c . -ben > Linus -- "Thought is the essence of where you are now."