From: Josh Triplett <josh@joshtriplett.org>
To: Joe Perches <joe@perches.com>
Cc: Ravi Patel <rapatel@apm.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Andy Whitcroft <apw@canonical.com>,
Kumar Sankaran <ksankaran@apm.com>, Loc Ho <lho@apm.com>,
Keyur Chudgar <kchudgar@apm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl error might be false positive
Date: Fri, 20 Dec 2013 09:03:09 -0800 [thread overview]
Message-ID: <20131220170308.GA26163@leaf> (raw)
In-Reply-To: <1387531432.2353.44.camel@joe-AO722>
On Fri, Dec 20, 2013 at 01:23:52AM -0800, Joe Perches wrote:
> On Fri, 2013-12-20 at 01:16 -0800, Josh Triplett wrote:
> > Duplicating the regex seems awful. Could you put it in a variable?
>
> awful is a strong word and I don't have any
> issue with the duplication. Using a variable
> is just as confusing as any duplication.
Fair enough; I don't care that much. For your patch:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
- Josh Triplett
prev parent reply other threads:[~2013-12-20 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN1v_PvS3dH6HVQ90d=3cfsSdMgieyoDNp3VN-vrHv-aqSFEAw@mail.gmail.com>
2013-12-19 22:15 ` checkpatch.pl error might be false positive Joe Perches
2013-12-20 7:56 ` Josh Triplett
2013-12-20 8:37 ` Joe Perches
2013-12-20 9:16 ` Josh Triplett
2013-12-20 9:23 ` Joe Perches
2013-12-20 17:03 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220170308.GA26163@leaf \
--to=josh@joshtriplett.org \
--cc=apw@canonical.com \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=kchudgar@apm.com \
--cc=ksankaran@apm.com \
--cc=lho@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rapatel@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox