From: Arnd Bergmann <arnd@arndb.de>
To: David Brown <davidb@codeaurora.org>
Cc: arm@kernel.org, Rohit Vaswani <rvaswani@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] ARM: msm: Add support for APQ8074 Dragonboard
Date: Fri, 20 Dec 2013 21:34:41 +0100 [thread overview]
Message-ID: <201312202134.42027.arnd@arndb.de> (raw)
In-Reply-To: <1387566560-23948-3-git-send-email-davidb@codeaurora.org>
On Friday 20 December 2013, David Brown wrote:
> diff --git a/arch/arm/mach-msm/board-dt.c b/arch/arm/mach-msm/board-dt.c
> index 16e6183..1f11d93 100644
> --- a/arch/arm/mach-msm/board-dt.c
> +++ b/arch/arm/mach-msm/board-dt.c
> @@ -26,7 +26,16 @@ static const char * const msm_dt_match[] __initconst = {
> NULL
> };
>
> +static const char * const apq8074_dt_match[] __initconst = {
> + "qcom,apq8074-dragonboard",
> + NULL
> +};
> +
> DT_MACHINE_START(MSM_DT, "Qualcomm MSM (Flattened Device Tree)")
> .smp = smp_ops(msm_smp_ops),
> .dt_compat = msm_dt_match,
> MACHINE_END
> +
> +DT_MACHINE_START(APQ_DT, "Qualcomm MSM (Flattened Device Tree)")
> + .dt_compat = apq8074_dt_match,
> +MACHINE_END
> --
Why can't you reuse the MSM_DT definition and just add the dragonboard
to the list of compatible machines? The presence of the smp_ops pointer
should not matter if you don't support SMP.
Arnd
next prev parent reply other threads:[~2013-12-20 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 19:09 [PATCH 0/7] MSM patches for 3.14 David Brown
2013-12-20 19:09 ` [PATCH 1/7] ARM: msm: trout: fix uninit var warning David Brown
2013-12-20 19:09 ` [PATCH 2/7] ARM: msm: Add support for APQ8074 Dragonboard David Brown
2013-12-20 20:34 ` Arnd Bergmann [this message]
2013-12-21 6:21 ` Stephen Boyd
2013-12-20 19:09 ` [PATCH 3/7] defconfig: msm_defconfig: Enable CONFIG_ARCH_MSM8974 David Brown
2013-12-20 19:09 ` [PATCH 4/7] ARM: msm: Simplify ARCH_MSM_DT config David Brown
2013-12-20 19:09 ` [PATCH 5/7] ARM: dts: MSM8974: Add restart node David Brown
2013-12-20 19:09 ` [PATCH 6/7] ARM: dts: MSM8974: Add MMIO architected timer node David Brown
2013-12-20 19:09 ` [PATCH 7/7] ARM: msm_defconfig: Enable restart driver David Brown
2014-01-02 18:31 ` [PATCH 0/7] MSM patches for 3.14 Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312202134.42027.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rvaswani@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox