* [PATCH] drivers: dwc2: Mark function as static in core.c
@ 2013-12-21 10:20 Rashika Kheria
2013-12-21 10:52 ` Josh Triplett
2014-01-08 23:47 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Rashika Kheria @ 2013-12-21 10:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Zimmerman, Greg Kroah-Hartman, linux-usb, devel, josh
Mark function dwc2_set_param_uframe_sched() as static in core.c because
it is not used outside this file.
This eliminates the following warning in core.c:
drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/staging/dwc2/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
index 6d001b5..c029cb6 100644
--- a/drivers/staging/dwc2/core.c
+++ b/drivers/staging/dwc2/core.c
@@ -2736,7 +2736,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)
return 0;
}
-int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
+static int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
{
int retval = 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: dwc2: Mark function as static in core.c
2013-12-21 10:20 [PATCH] drivers: dwc2: Mark function as static in core.c Rashika Kheria
@ 2013-12-21 10:52 ` Josh Triplett
2014-01-08 23:47 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Josh Triplett @ 2013-12-21 10:52 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Paul Zimmerman, Greg Kroah-Hartman, linux-usb,
devel
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote:
> Mark function dwc2_set_param_uframe_sched() as static in core.c because
> it is not used outside this file.
>
> This eliminates the following warning in core.c:
> drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/staging/dwc2/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
> index 6d001b5..c029cb6 100644
> --- a/drivers/staging/dwc2/core.c
> +++ b/drivers/staging/dwc2/core.c
> @@ -2736,7 +2736,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)
> return 0;
> }
>
> -int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
> +static int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
> {
> int retval = 0;
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: dwc2: Mark function as static in core.c
2013-12-21 10:20 [PATCH] drivers: dwc2: Mark function as static in core.c Rashika Kheria
2013-12-21 10:52 ` Josh Triplett
@ 2014-01-08 23:47 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-01-08 23:47 UTC (permalink / raw)
To: Rashika Kheria; +Cc: linux-kernel, devel, linux-usb, Paul Zimmerman, josh
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote:
> Mark function dwc2_set_param_uframe_sched() as static in core.c because
> it is not used outside this file.
>
> This eliminates the following warning in core.c:
> drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
This patch doesn't apply to my tree.
And please stop sending patches in base64 mode, it makes it impossible
to add reviewed-by: markings to them.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-08 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 10:20 [PATCH] drivers: dwc2: Mark function as static in core.c Rashika Kheria
2013-12-21 10:52 ` Josh Triplett
2014-01-08 23:47 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox