Re: [PATCH 1/2] drivers: dgap: Include appropriate header file in dgap_parse.c

Josh Triplett
2013-12-21T10:55:43Z

On Sat, Dec 21, 2013 at 03:55:50PM +0530, Rashika Kheria wrote:
> Include appropriate header file in dgap/dgap_parse.h in dgap_parse.c
> because functions dgap_parsefile(), dgap_config_get_useintr(),
> dgap_config_get_altpin(), dgap_find_config(),
> dgap_config_get_number_of_ports(), dgap_create_config_string() and
> dgap_get_config_letters() have their prototype declarations in the
> header file.
>
> This eliminates the following warnings in dgap_parse.c:
> drivers/staging/dgap/dgap_parse.c:125:5: warning: no previous prototype for ‘dgap_parsefile’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1101:6: warning: no previous prototype for ‘dgap_config_get_useintr’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1128:6: warning: no previous prototype for ‘dgap_config_get_altpin’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1157:15: warning: no previous prototype for ‘dgap_find_config’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1223:6: warning: no previous prototype for ‘dgap_config_get_number_of_ports’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1252:7: warning: no previous prototype for ‘dgap_create_config_string’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1311:7: warning: no previous prototype for ‘dgap_get_config_letters’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> drivers/staging/dgap/dgap_parse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/dgap/dgap_parse.c b/drivers/staging/dgap/dgap_parse.c
> index ff9d194..36fd93d 100644
> --- a/drivers/staging/dgap/dgap_parse.c
> +++ b/drivers/staging/dgap/dgap_parse.c
> @@ -42,6 +42,7 @@
> #include "dgap_types.h"
> #include "dgap_fep5.h"
> #include "dgap_driver.h"
> +#include "dgap_parse.h"
> #include "dgap_conf.h"
>
>
> --
> 1.7.9.5
>