* [PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c
@ 2013-12-21 10:28 Rashika Kheria
2013-12-21 10:55 ` Josh Triplett
0 siblings, 1 reply; 2+ messages in thread
From: Rashika Kheria @ 2013-12-21 10:28 UTC (permalink / raw)
To: linux-kernel
Cc: Lidza Louina, Greg Kroah-Hartman, driverdev-devel, devel, josh
Include appropriate header file dgap/dgap_trace.h in dgap_trace.c
because function dgap_tracer_free() have its prototype declaration in
the header file.
This eliminates the following warning in dgap_trace.c:
drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for ‘dgap_tracer_free’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/staging/dgap/dgap_trace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/dgap/dgap_trace.c b/drivers/staging/dgap/dgap_trace.c
index 0f9a956..6c8b510 100644
--- a/drivers/staging/dgap/dgap_trace.c
+++ b/drivers/staging/dgap/dgap_trace.c
@@ -37,6 +37,7 @@
#include <linux/vmalloc.h>
#include "dgap_driver.h"
+#include "dgap_trace.h"
#define TRC_TO_CONSOLE 1
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c
2013-12-21 10:28 [PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c Rashika Kheria
@ 2013-12-21 10:55 ` Josh Triplett
0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2013-12-21 10:55 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Lidza Louina, Greg Kroah-Hartman, driverdev-devel,
devel
On Sat, Dec 21, 2013 at 03:58:25PM +0530, Rashika Kheria wrote:
> Include appropriate header file dgap/dgap_trace.h in dgap_trace.c
> because function dgap_tracer_free() have its prototype declaration in
> the header file.
>
> This eliminates the following warning in dgap_trace.c:
> drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for ‘dgap_tracer_free’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/staging/dgap/dgap_trace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/dgap/dgap_trace.c b/drivers/staging/dgap/dgap_trace.c
> index 0f9a956..6c8b510 100644
> --- a/drivers/staging/dgap/dgap_trace.c
> +++ b/drivers/staging/dgap/dgap_trace.c
> @@ -37,6 +37,7 @@
> #include <linux/vmalloc.h>
>
> #include "dgap_driver.h"
> +#include "dgap_trace.h"
>
> #define TRC_TO_CONSOLE 1
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-21 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 10:28 [PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c Rashika Kheria
2013-12-21 10:55 ` Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox