From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Iyappan Subramanian <isubramanian@apm.com>,
davem@davemloft.net, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, patches@apm.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jcm@redhat.com, Keyur Chudgar <kchudgar@apm.com>,
Ravi Patel <rapatel@apm.com>
Subject: Re: [PATCH 1/5] Documentation: APM X-Gene SoC Ethernet DTS binding documentation
Date: Sun, 22 Dec 2013 10:40:47 +0100 [thread overview]
Message-ID: <201312221040.47822.arnd@arndb.de> (raw)
In-Reply-To: <1387597376-29303-2-git-send-email-isubramanian@apm.com>
On Saturday 21 December 2013, Iyappan Subramanian wrote:
> @@ -0,0 +1,67 @@
> +APM X-Gene SoC Ethernet nodes
> +
> +Ethernet nodes are defined to describe on-chip ethernet interfaces in
> +APM X-Gene SoC. Ethernet subsystem communicates with a central Queue Manager
> +(QMTM) using messages for transmit, receive and allocating data buffers.
> +There are multiple ethernet interfaces in APM X-Gene SoC. Each ethernet
> +interface has its own node. Its corresponding clock nodes are shown below.
> +
> +Required properties:
> +- compatible : Shall be "apm,xgene-enet"
> +- reg : First memory resource shall be the Ethernet CSR
> + memory resource for indirect MAC access.
> + Second memory resource shall be the Ethernet CSR
> + memory resource.
> + Third memory resource shall be the Ethernet CSR
> + memory resource for indirect MII access.
What is a "CSR"?
> +- interrupts : First interrupt resource shall be the Ethernet global
> + Error interrupt.
> + : Second interrupt resource shall be the Ethernet MAC
> + Error interrupt.
> + : Third interrupt resource shall be the Ethernet QM
> + interface interrupt.
No regular interrupts?
> +- clocks : Reference to the clock entry.
> +- local-mac-address : Shall be ethernet mac address.
> +- max-frame-size : Shall be maximum ethernet frame size.
> +- devid : Shall be ethernet interface number.
> +- phyid : Shall be ethernet MII phy address.
> +- phy-mode : Shall be ethernet MII mode.
Can you explain what the interface number is for?
Is the phy actually part of the ethernet device? Since it has its
own register range, it seems likely that it's actually a separate
device that just happens to be used together with the mac and should
have its own device node and driver.
Arnd
next prev parent reply other threads:[~2013-12-22 9:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 3:42 [PATCH 0/5] drivers: net: Adding support for APM X-Gene SoC Ethernet base driver Iyappan Subramanian
2013-12-21 3:42 ` [PATCH 1/5] Documentation: APM X-Gene SoC Ethernet DTS binding documentation Iyappan Subramanian
2013-12-22 9:40 ` Arnd Bergmann [this message]
2013-12-21 3:42 ` [PATCH 2/5] arm64: dts: APM X-Gene SoC Ethernet device tree nodes Iyappan Subramanian
2014-01-24 17:01 ` Mark Salter
2014-04-11 20:03 ` Iyappan Subramanian
2014-05-09 15:29 ` Alex Bennée
2013-12-21 3:42 ` [PATCH 3/5] drivers: net: APM X-Gene SoC Ethernet base driver Iyappan Subramanian
2013-12-21 21:11 ` Greg KH
2013-12-21 3:42 ` [PATCH 4/5] drivers: net: APM X-Gene SoC Ethernet driver error handling Iyappan Subramanian
2013-12-22 9:34 ` Arnd Bergmann
2013-12-21 3:42 ` [PATCH 5/5] drivers: net: APM X-Gene SoC Ethernet driver ethtool support Iyappan Subramanian
2013-12-22 9:35 ` [PATCH 0/5] drivers: net: Adding support for APM X-Gene SoC Ethernet base driver Arnd Bergmann
2013-12-23 16:32 ` Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312221040.47822.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=isubramanian@apm.com \
--cc=jcm@redhat.com \
--cc=kchudgar@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=patches@apm.com \
--cc=rapatel@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox