Re: [PATCH] closures: move to lib/

Kent Overstreet
2013-12-19T01:37:10Z

On Wed, Dec 18, 2013 at 05:34:31PM -0800, Dan Williams wrote:
> On Wed, Dec 18, 2013 at 5:29 PM, Kent Overstreet <kmo@daterainc.com> wrote:
> > the closure code was never intended to be bcache specific - hopefully it can be
> > useful elsewhere in the kernel.
> >
> > Signed-off-by: Kent Overstreet <kmo@daterainc.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Arjan van de Ven <arjan@linux.intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > ---
> > drivers/md/bcache/Kconfig | 9 -
> > drivers/md/bcache/Makefile | 2 +-
> > drivers/md/bcache/bcache.h | 2 +-
> > drivers/md/bcache/closure.c | 222 ----------------------
> > drivers/md/bcache/closure.h | 453 --------------------------------------------
> > drivers/md/bcache/util.h | 3 +-
> > include/linux/closure.h | 451 +++++++++++++++++++++++++++++++++++++++++++
> > lib/Kconfig.debug | 8 +
> > lib/Makefile | 2 +-
> > lib/closure.c | 218 +++++++++++++++++++++
> > 10 files changed, 681 insertions(+), 689 deletions(-)
> > delete mode 100644 drivers/md/bcache/closure.c
> > delete mode 100644 drivers/md/bcache/closure.h
> > create mode 100644 include/linux/closure.h
> > create mode 100644 lib/closure.c
>
> This would be smaller to review with git diff -M

I forgot to mention - this is on top of other stuff I have queued up which
deletes a fair amount of code in closure.[ch] (finally got rid of some stuff
Tejun hated).