The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Caizhiyong <caizhiyong@hisilicon.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"Wanglin (Albert)" <albert.wanglin@hisilicon.com>,
	David Woodhouse <David.Woodhouse@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Subject: Re: [PATCH] mtd: nand:  assign mtd->name in find_full_id_nand
Date: Thu, 26 Dec 2013 10:19:39 +0800	[thread overview]
Message-ID: <20131226021937.GA6752@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <C3050A4DBA34F345975765E43127F10F25E47E20@SZXEMA512-MBX.china.huawei.com>

On Thu, Dec 26, 2013 at 01:51:58AM +0000, Caizhiyong wrote:
> From: Cai Zhiyong <caizhiyong@huawei.com>
> Date: Wed, 25 Dec 2013 21:19:21 +0800
> Subject: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand
> 
> This patch assigned the type->name to mtd->name when mtd->name is
> NULL in function "find_full_id_nand".
> mtd->name is NULL may cause some problem.
> 
> Signed-off-by: Cai Zhiyong <caizhiyong@huawei.com>
> ---
>  drivers/mtd/nand/nand_base.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 9b3bb3c..404e83d 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3327,6 +3327,9 @@ static bool find_full_id_nand(struct mtd_info *mtd, struct nand_chip *chip,
>  
>  		*busw = type->options & NAND_BUSWIDTH_16;
>  
> +		if (!mtd->name)
> +			mtd->name = type->name;
> +
>  		return true;
>  	}
>  	return false;
Acked-by: Huang Shijie <b32955@freescale.com>


  reply	other threads:[~2013-12-26  2:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-26  1:51 [PATCH] mtd: nand: assign mtd->name in find_full_id_nand Caizhiyong
2013-12-26  2:19 ` Huang Shijie [this message]
2014-01-11 20:10   ` Brian Norris
2014-01-13  4:12     ` Caizhiyong
2014-01-13  7:46       ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131226021937.GA6752@shlinux2.ap.freescale.net \
    --to=b32955@freescale.com \
    --cc=David.Woodhouse@intel.com \
    --cc=albert.wanglin@hisilicon.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=caizhiyong@hisilicon.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox