From: "H.J. Lu" <hjl.tools@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use __kernel_ulong_t in uapi struct ipc64_perm
Date: Thu, 26 Dec 2013 07:38:59 -0800 [thread overview]
Message-ID: <20131226153859.GD23355@gmail.com> (raw)
In-Reply-To: <20131225154541.GA12109@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Wed, Dec 25, 2013 at 07:45:41AM -0800, H.J. Lu wrote:
> X32 IPC system call is the same as x86-64 IPC system call, which uses
> 64-bit integer for unsigned long in struct ipc64_perm. But x32 long is
> 32 bit. This patch replaces unsigned long in uapi struct ipc64_perm with
> __kernel_ulong_t.
>
Here is the updated patch which uses __kernel_ulong_t only if
__BITS_PER_LONG == 64.
H.J.
[-- Attachment #2: 0003-Use-__kernel_ulong_t-in-uapi-struct-ipc64_perm.patch --]
[-- Type: text/plain, Size: 1150 bytes --]
>From 81b4c3c55f994d54eafcaf4adaa2a16786c41fdd Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 25 Dec 2013 07:13:02 -0800
Subject: [PATCH] Use __kernel_ulong_t in uapi struct ipc64_perm
X32 IPC system call is the same as x86-64 IPC system call, which uses
64-bit integer for unsigned long in struct ipc64_perm. But x32 long is
32 bit. This patch replaces unsigned long in uapi struct ipc64_perm with
__kernel_ulong_t if __BITS_PER_LONG == 64.
Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
---
include/uapi/asm-generic/ipcbuf.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/uapi/asm-generic/ipcbuf.h b/include/uapi/asm-generic/ipcbuf.h
index 76982b2..4635fa5 100644
--- a/include/uapi/asm-generic/ipcbuf.h
+++ b/include/uapi/asm-generic/ipcbuf.h
@@ -27,8 +27,13 @@ struct ipc64_perm {
unsigned char __pad1[4 - sizeof(__kernel_mode_t)];
unsigned short seq;
unsigned short __pad2;
+#if __BITS_PER_LONG == 64
+ __kernel_ulong_t __unused1;
+ __kernel_ulong_t __unused2;
+#else
unsigned long __unused1;
unsigned long __unused2;
+#endif
};
#endif /* __ASM_GENERIC_IPCBUF_H */
--
1.8.4.2
prev parent reply other threads:[~2013-12-26 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 15:45 [PATCH] Use __kernel_ulong_t in uapi struct ipc64_perm H.J. Lu
2013-12-26 15:38 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226153859.GD23355@gmail.com \
--to=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox