From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 0/9] tools: Factor traceevent/perf Makefile
Date: Thu, 26 Dec 2013 21:10:07 +0100 [thread overview]
Message-ID: <20131226201007.GA1213@krava.brq.redhat.com> (raw)
In-Reply-To: <20131226133842.GA30980@ghostprotocols.net>
On Thu, Dec 26, 2013 at 10:38:42AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 19, 2013 at 02:41:58PM +0100, Jiri Olsa escreveu:
> > hi,
> > sending out the change to introduce single:
> > INSTALL trace_plugins
> > build output line. Some more code factoring was needed.
> >
> > Also updated the tests/make install tests to check for
> > installed plugins.
>
> Ok, better now, applied, but can you take a look at:
>
> [acme@ssdandy linux]$ make O=/tmp/build/perf -C tools/perf/ install-bin
> make: Entering directory `/home/acme/git/linux/tools/perf'
> BUILD: Doing 'make -j8' parallel build
> GEN perf-archive
> SUBDIR /home/acme/git/linux/tools/lib/traceevent/
> make[3]: Nothing to be done for `plugins'.
> make[2]: Nothing to be done for `plugins'.
> INSTALL GTK UI
> INSTALL binaries
> INSTALL libexec
> INSTALL perf-archive
> INSTALL perl-scripts
> INSTALL python-scripts
> INSTALL perf_completion-script
> INSTALL tests
> make: Leaving directory `/home/acme/git/linux/tools/perf'
> [acme@ssdandy linux]$
>
> Removing those two "Nothing to be done" lines, please?
never happy, are we? ;-) looks like change below
would do.. I'll check/test more and send out.
jirka
---
diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
index 8abbef1..555de0b 100644
--- a/tools/scripts/Makefile.include
+++ b/tools/scripts/Makefile.include
@@ -55,7 +55,7 @@ descend = \
+mkdir -p $(OUTPUT)$(1) && \
$(MAKE) $(COMMAND_O) subdir=$(if $(subdir),$(subdir)/$(1),$(1)) $(PRINT_DIR) -C $(1) $(2)
-QUIET_SUBDIR0 = +$(MAKE) $(COMMAND_O) -C # space to separate -C and subdir
+QUIET_SUBDIR0 = +$(MAKE) $(COMMAND_O) -s -C # space to separate -C and subdir
QUIET_SUBDIR1 =
ifneq ($(findstring $(MAKEFLAGS),s),s)
next prev parent reply other threads:[~2013-12-26 20:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 13:41 [PATCH 0/9] tools: Factor traceevent/perf Makefile Jiri Olsa
2013-12-19 13:41 ` [PATCH 1/9] perf tests: Factor make install tests Jiri Olsa
2014-01-12 18:33 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 2/9] perf tools: Making QUIET_(CLEAN|INSTAL) variables global Jiri Olsa
2014-01-12 18:33 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 3/9] tools lib traceevent: Remove print_app_build variable Jiri Olsa
2014-01-12 18:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 4/9] tools lib traceevent: Use global QUIET_CC build output Jiri Olsa
2014-01-12 18:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 5/9] tools lib traceevent: Add global QUIET_CC_FPIC " Jiri Olsa
2014-01-12 18:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 6/9] tools lib traceevent: Use global QUIET_LINK " Jiri Olsa
2014-01-12 18:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 7/9] tools lib traceevent: Use global QUIET_INSTALL " Jiri Olsa
2014-01-12 18:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 8/9] tools lib traceevent: Use global QUIET_CLEAN " Jiri Olsa
2014-01-12 18:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-19 13:42 ` [PATCH 9/9] tools lib traceevent: Use global 'O' processing code Jiri Olsa
2014-01-12 18:35 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-12-20 17:33 ` [PATCH 0/9] tools: Factor traceevent/perf Makefile Jiri Olsa
2013-12-26 13:38 ` Arnaldo Carvalho de Melo
2013-12-26 20:10 ` Jiri Olsa [this message]
2013-12-26 20:52 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226201007.GA1213@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox