From: Greg KH <gregkh@linuxfoundation.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Tushar Behera <tushar.behera@linaro.org>,
linux-serial <linux-serial@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>, jslaby <jslaby@suse.cz>,
Patch Tracking <patches@linaro.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] serial: samsung: Remove hard-coded major/minor numbers
Date: Thu, 26 Dec 2013 22:49:24 -0800 [thread overview]
Message-ID: <20131227064924.GA3799@kroah.com> (raw)
In-Reply-To: <1388126603.342451910@f289.i.mail.ru>
On Fri, Dec 27, 2013 at 10:43:23AM +0400, Alexander Shiyan wrote:
> Hello.
> > On Fri, Dec 27, 2013 at 12:00:20PM +0530, Tushar Behera wrote:
> > > On 27 December 2013 10:48, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > > On Fri, Dec 27, 2013 at 10:37:28AM +0530, Tushar Behera wrote:
> > > >> The hard-coded values clash with the values set for amba-pl011 serial
> > > >> driver. Because of this there is no serial output on Samsung boards
> > > >> if amba-pl011 is enabled alongwith samsung-serial driver.
> > > >>
> > > >> Remove the hardcoded values and let the framework decide on
> > > >> appropriate major/minor number. This is required for multi-platform
> > > >> development work on Exynos platform.
> > > >>
> > > >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ...
> > > >> #define S3C24XX_SERIAL_NAME "ttySAC"
> > > >> -#define S3C24XX_SERIAL_MAJOR 204
> > > >> -#define S3C24XX_SERIAL_MINOR 64
> > > >>
> > > >> /* macros to change one thing to another */
> > > >>
> > > >> @@ -951,8 +949,6 @@ static struct uart_driver s3c24xx_uart_drv = {
> > > >> .nr = CONFIG_SERIAL_SAMSUNG_UARTS,
> > > >> .cons = S3C24XX_SERIAL_CONSOLE,
> > > >> .dev_name = S3C24XX_SERIAL_NAME,
> > > >> - .major = S3C24XX_SERIAL_MAJOR,
> > > >> - .minor = S3C24XX_SERIAL_MINOR,
> > > >
> > > > Doesn't this break existing systems and configurations that are
> > > > expecting 204:64 as the location of this serial port?
> > > >
> > >
> > > I tested this on Exynos4210-Origen, Exynos5250-Arndale board, it works
> > > fine there. I haven't tested on any older boards.
> >
> > How did it work? You are relying on some userspace tools to do this
> > properly, right? What about systems without those specific tools?
>
> Can this issue be resolved by using MODULE_ALIAS_CHARDEV()
> in the driver code?
How exactly would that work?
next prev parent reply other threads:[~2013-12-27 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 5:07 [PATCH] serial: samsung: Remove hard-coded major/minor numbers Tushar Behera
2013-12-27 5:18 ` Greg KH
2013-12-27 6:30 ` Tushar Behera
2013-12-27 6:38 ` Greg KH
2013-12-27 6:43 ` Alexander Shiyan
2013-12-27 6:49 ` Greg KH [this message]
2013-12-27 10:17 ` Tushar Behera
2013-12-27 18:44 ` Greg KH
2013-12-31 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131227064924.GA3799@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=patches@linaro.org \
--cc=shc_work@mail.ru \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox